qwat / QWAT

TEKSI Water module (project QWAT) - QGIS project
https://www.teksi.ch
GNU General Public License v2.0
58 stars 31 forks source link

Missing pipe materials with various nominal pressure (PN)... or missing something else ? #310

Open kandre opened 3 years ago

kandre commented 3 years ago

Knowing nominal pressure (PN) of pipes is quite important especially for operations department. As far as I know, nominal pressure is stored on pipes in QWAT. However, when installing pipes, there are parts constituing a pipe (other than the pipe cylinder itself) that can have their own nominal pressure. Theses part can be flanges ("brides"), valves, etc. and for some are not part of the model or does not have such attribute.

Indeed I learned that in some cases, it is possible to install flanges with different nominal pressure than the pipe cylinder. Therefore I have always considered and instructed that one should fill the pipe nominal pressure using the part that has the smallest nominal pressure. However, with this method, we lack some material-PN combinations for cast iron materials such as FAE 200 PN 10, FAE 200 PN 16, etc.

Has anyone already encounter this problem and how would you solve it ?

I think we should decide if whether we would:

  1. add new material values in pipe_material value list and use my suggested method while filling pipes forms
  2. extend the model by adding new parts with nominal pressure, and adding nominal pressure attribute onto some existing components

I would go for solution 1. because it seem way easier to implement and to use it. It also can be used right now on both new and old data even if we dont have existing parts stored in the database. Finally, I would prefer not be alone by filling nominal pressure information that way.

ponceta commented 3 years ago

I would also go for 1.

Maybe @tudorbarascu has some interesting feedbacks on this?

tudorbarascu commented 3 years ago

This is tied to https://github.com/qwat/qwat-data-model/issues/107