qwat / QWAT

TEKSI Water module (project QWAT) - QGIS project
https://www.teksi.ch
GNU General Public License v2.0
58 stars 31 forks source link

Why the data model folder is pointing to an older commit instead of the master branch of the data model repo? #314

Open nicolas-sitylb opened 3 years ago

nicolas-sitylb commented 3 years ago

Hello,

I have a naive question, but when cloning the main qwat/QWAT repo', the folder of the data model in that repository looks like this at the moment of writing: image and points to an old commit which is not referenced as a branch: https://github.com/qwat/qwat-data-model/tree/23ddd9bed3501fdaba6eaf9764cd9963116f1b4e

Instead, I would "naturally" expect the data model folder to also reference the master branch of the qwat/qwat-data-model repository, namely this one: https://github.com/qwat/qwat-data-model/tree/master

So, why is it referencing this old 23ddd9b commit instead of the master? And would it make sense to change it so that the master branch of the qwat/QWAT repo' makes use of the master branch of the data model repository?

What would be the way of using the master version of the data model? git submodule update --init --recursive doesn't seem to upgrade it to its latest version. Instead, after cloning the main qwat/QWAT repo', this command switches the data model folder to that 23ddd9b old commit, which is in a DETACHED state (this is definitely not a good practice?)

ponceta commented 3 years ago

Hi,

We actually provide the latest datamodel version for users.

Latest released version is actually 1.3.5 (december 2020), 1.3.6 is coming soon.

Master branch can be broken when pushing new features, that's why we rely on tagged releases to provide the best experience.

The project folder should follow these published versions when possible.

git submodule update --init --recursive will update only till latest release mention in the git versionning.

All these prerequisite with git workflows will be reviewed and simplified next year on QWAT and QGEP projects.

We will also review the roadmap for both projects until the end of the year.