search

qwat / qwat-data-model

TEKSI Water module (project QWAT) - PostgreSQL / postgis Datamodel
https://www.teksi.ch
23 stars 24 forks source link

Fixes init_qwat and upgrade_db.sh #228

Closed lbartoletti closed 6 years ago

lbartoletti commented 6 years ago

  1. Replace more gnued/linuxism script 1.1. getopt Using long args with getopt is a linuxism. So I include a "compat mode" for it. More details on stackoverflow 1.2. sed sed r is the GNU sed version. Use coreutils with gsed for non linux. Or easiest, use cat 1.3. sleep Use only the number of seconds without the suffix.

  2. upgrade_db.sh 2.1. SCRIPTDIR Add the location of the script. Since you can run it everywhere 2.2. DB info from pg_service.conf TODO is done. Get the host and the port for dbcomp and dbtest. Maybe add an option for the location of .pg_service.conf? Wouldn't it be better if this part were done by PUM?

sylvainbeo commented 6 years ago

Looks good to me.

haubourg commented 6 years ago

reviewed also by @mhugo :) >> merging