search

qwat / qwat-data-model

TEKSI Water module (project QWAT) - PostgreSQL / postgis Datamodel
https://www.teksi.ch
23 stars 24 forks source link

Add service arg everywhere #241

Closed lbartoletti closed 6 years ago

lbartoletti commented 6 years ago

A service is required and it's explicit with this command. This adds security in case when the service is not found/exported. (I found one case, that I need to investigate).

elemoine commented 6 years ago

Do you also want to remove the export PGSERVICE statements from init_qwat.sh, tests.sh, tests_scalability.sh and tests_scalability_multithread.sh?

elemoine commented 6 years ago

Just one comment, otherwise +1 with making this explicit.

lbartoletti commented 6 years ago

yak shaving was near :)

haubourg commented 6 years ago

Ready for merge ?

lbartoletti commented 6 years ago

Yes

elemoine commented 6 years ago

I just tested init_qwat.sh with your patch applied. Both

$ ./init_qwat.sh -p qwat -s 21781 -d -r

and

$ PGSERVICE=qwat ./init_qwat.sh -s 21781 -d -r

worked perfectly.

Now I did not bother running all the other scripts.

Good to merge to me. Thanks @lbartoletti.