search

qwat / qwat-data-model

TEKSI Water module (project QWAT) - PostgreSQL / postgis Datamodel
https://www.teksi.ch
23 stars 24 forks source link

WIP: Make changes for Pum 0.6 #249

Closed elemoine closed 5 years ago

elemoine commented 6 years ago

In Pum 0.6 (and higher) the version flag was changed for -v to -V. This PR accomodates for this change.

Also, there's a regression in Pum 0.6. See https://github.com/opengisch/pum/pull/38. Commit f3e233c tests that the fix for the regression does work for QWAT. I'll remove that commit when there's a new Pum release on pypi.

elemoine commented 6 years ago

Ok, https://github.com/opengisch/pum/pull/38 fixes the problems. Let's wait for a new Pum release before merging this.

3nids commented 6 years ago

@elemoine would you prefer me to revert the -v/-V change or we keep the new one?

elemoine commented 6 years ago

@elemoine would you prefer me to revert the -v/-V change or we keep the new one?

Yes, that would make sense to me. I think -v is more natural.

lbartoletti commented 5 years ago

@elemoine Do you think this can be fixed and integrated into 1.3.3?

elemoine commented 5 years ago

I've just checked with Pum 0.7.1 (the latest version), and pum -v (lower-case v) does output the version again. So this PR can just be closed.