Add SIA405 strings to value lists [WIP/STUB]

[olivierdalang]

This is needed to import from/to SIA405.

Actual matching is just a stub so far. @sjib Could your metadatabase scripts by any chance help in automating the matching ? Or do we need to do that by hand ?

[olivierdalang]

Added new commits :

• renamed column sia405_de by sia405code
• replaced "unbekannt" by NULL when possible (non mandatory fields)
• did matching for some required value lists

[olivierdalang]

Todo before merging

• [ ] complete matching until we reach an acceptable matching
• [ ] cleanup (remove value_list_sia405.sql and define the sia405codes directly in the vl_*.sql files)

[olivierdalang]

@ponceta @sjib Hey ! Let me know when you're done with the first pass so that I can merge this. As we discussed, it doesn't need to be perfect, just the minimum for the export to contain useful information. We'll improve incrementally afterwards.

With the current file, I get the following validation errors when exporting the demo data :

Error: line 1770: SIA405_WASSER_2015_LV95.SIA405_Wasser.Leitung: tid ch00000000006265: value Kunststoff is not a member of the enumeration in attribute Material
Error: line 6311: SIA405_WASSER_2015_LV95.SIA405_Wasser.Schadenstelle: tid ch00000000008730: value Bruch.Riss is not a member of the enumeration in attribute Art

I guess we want Riss intead of Bruch.Riss, and some subvalue of Kunststoff

[sjib]

Yes-- Stefan BurckhardtAm 10.08.21, 11:07 schrieb Olivier Dalang @.***>:

@ponceta @sjib Hey ! Let me know when you're done with the first pass so that I can merge this. As we discussed, it doesn't need to be perfect, just the minimum for the export to contain useful information. We'll improve incrementally afterwards. With the current file, I get the following validation errors when exporting the demo data : Error: line 1770: SIA405_WASSER_2015_LV95.SIA405_Wasser.Leitung: tid ch00000000006265: value Kunststoff is not a member of the enumeration in attribute Material Error: line 6311: SIA405_WASSER_2015_LV95.SIA405_Wasser.Schadenstelle: tid ch00000000008730: value Bruch.Riss is not a member of the enumeration in attribute Art

I guess we want Riss intead of Bruch.Riss, and some subvalue of Kunststoff —You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android.

[ponceta]

Indeed, @olivierdalang feel free to adapt what is necessary to have the minimal export running.

[lbartoletti]

@olivierdalang is the file update/delta/delta_1.3.6_add_vl_for_SIA_export.sql should be named update/delta/delta_1.3.6_000_add_vl_for_SIA_export.sql?

[olivierdalang]

@lbartoletti Not sure I understand, what is wrong with delta_1.3.6_add_vl_for_SIA_export.sql ?

[lbartoletti]

@olivierdalang By convention - don't remember if it was required by pum or the CI - deltas have a 3 digits id to perform update. IIRC to be performed in a specific order

[olivierdalang]

ah ok, in this case I don't think it's necessary as we're already released 1.3.6 (beta) so that the next would be 1.3.7. It would be useful in the case where we could have multiple deltas in the same version, to ensure they apply in correct order.