search

qwat / qwat-data-model

TEKSI Water module (project QWAT) - PostgreSQL / postgis Datamodel
https://www.teksi.ch
23 stars 24 forks source link

Continuous Integration CI : Unit test are no longer running on pull requests #348

Closed ponceta closed 1 year ago

ponceta commented 2 years ago

Coherency control and sql statements are not tested anymore in an automatic way which can result in problems when upgrading to latest versions.

ponceta commented 1 year ago

AS discussed with @3nids, has to be fixed before 1.4.0 release.

ponceta commented 1 year ago

Travis scripts still need a GitHub Actions integration

https://github.com/qwat/qwat-data-model/tree/master/.build

ponceta commented 1 year ago

@olivierdalang thank you for what has been achieved!

We still have :

image

ponceta commented 1 year ago

image

https://github.com/qwat/qwat-data-model/actions/runs/3443193005/jobs/5744493765#step:9:2219

olivierdalang commented 1 year ago
  • [ ] To look why the specified postgresql is not used in the tests

I think it runs against 9.6, but with a 12.12 client (installed in the apt-get install postgresql-client step). IMO this is fine, as it will still correctly test all database side logic, and newer clients do support older backends.

  • [ ] To have similar docker images tested like for qgep

Yes that would be nice (also worth a rewamp in the QGEP side), but IMO not really related to testing ? I see it more a nice to have for quick deployment of a demo database.

  • [ ] To have similar behaviour to be able to start and redo the testing on a PR.

Not sure what you mean here ?

  • [ ] Run upgrade tests can have errors and still be flaged as successful!

Are you talking about the errors in restore (which could be harmless, as the role error you mentionned), or in the actual pum upgrade ? (the later should definitely be catched, if it's not the case can you point me towards where you saw this happen ?).

For now the results of the upgrade are just tested with pum check, but that does not take any content into account. Not sure if the QWAT test suite relies on the demo data, if yes we could also run tests agains the upgraded db to try catching some data related upgrade error.

  • [ ] roles have to be created before restoring the database

I think it would mean add the --create-roles to init_qwat.sh. But it seems none of the test actually make any usage of these roles. Thus I think we can just leave it like that as long as roles are considered an optional component of QWAT (btw I think it would be a good move to move them to core and to start to test them as well, same applies to QGEP).

sjib commented 1 year ago

I think it would mean add the --create-roles to init_qwat.sh. But it seems none of the test actually make any usage of these roles. Thus I think we can just leave it like that as long as roles are considered an optional component of QWAT (btw I think it would be a good move to move them to core and to start to test them as well, same applies to QGEP).

@ponceta Can we open two new issues for this?

ponceta commented 1 year ago

https://github.com/qwat/qwat-data-model/issues/370 https://github.com/qwat/qwat-data-model/issues/371

Done