search

qwat / qwat-data-model

TEKSI Water module (project QWAT) - PostgreSQL / postgis Datamodel
https://www.teksi.ch
23 stars 24 forks source link

Avoid references to productions views directly (prefer tables) #363

Closed ponceta closed 1 year ago

ponceta commented 1 year ago

Example of how export views should look like VS reference to productions views like vw_element_hydrant

ponceta commented 1 year ago

@olivierdalang this should avoid any troubles with having locks on editing views.

IMHO it would be to extend this to any export views as said in

https://github.com/qwat/qwat-data-model/pull/354

ponceta commented 1 year ago

No delta is required (views only)

olivierdalang commented 1 year ago

A bit difficult to review for me, as I have 0 context as to how this is used. Purely from the code it looks fine though, so I'd say if you tested and it seems to still work, it's ok to merge.

Merging this should be coordinated with https://github.com/qwat/qwat-data-model/pull/365 (to ensure we remove the hotfix for sigip, which otherwise will be untested)