Had to do some testing infrastructure related changes, and two actual fixes:
specify a precision for test data inserted in qwat_od.cover (otherwise it fails because of non null - I guess it's a relatively new constraint ?)
add vl_leak_type.sql in init_qwat.sh (seems that was forgotten in recent changes)
I'm not familiar with the test suite however, so not exactly sure how much we can rely on them.
What seems not tested at all is the upgrade scripts. The test use init_qwat.sh which runs the SQLs directly. We should probably also include a test that starts with version 1.0, and upgrades with pum, and then checks the consistency of the upgraded model with the init_qwat model, like we do for QGEP. This is done a followup PR since this is likely to require actual fixes to the datamodel : https://github.com/qwat/qwat-data-model/pull/365
Seems to pass.
Had to do some testing infrastructure related changes, and two actual fixes:
vl_leak_type.sql
ininit_qwat.sh
(seems that was forgotten in recent changes)I'm not familiar with the test suite however, so not exactly sure how much we can rely on them.
What seems not tested at all is the upgrade scripts. The test use
init_qwat.sh
which runs the SQLs directly. We should probably also include a test that starts with version 1.0, and upgrades with pum, and then checks the consistency of the upgraded model with theinit_qwat
model, like we do for QGEP. This is done a followup PR since this is likely to require actual fixes to the datamodel : https://github.com/qwat/qwat-data-model/pull/365