qwat / qwat-data-model

TEKSI Water module (project QWAT) - PostgreSQL / postgis Datamodel
https://www.teksi.ch
23 stars 25 forks source link

[CI] (re?)enable tests in CI #364

Closed olivierdalang closed 1 year ago

olivierdalang commented 2 years ago

Seems to pass.

Had to do some testing infrastructure related changes, and two actual fixes:

I'm not familiar with the test suite however, so not exactly sure how much we can rely on them.

What seems not tested at all is the upgrade scripts. The test use init_qwat.sh which runs the SQLs directly. We should probably also include a test that starts with version 1.0, and upgrades with pum, and then checks the consistency of the upgraded model with the init_qwat model, like we do for QGEP. This is done a followup PR since this is likely to require actual fixes to the datamodel : https://github.com/qwat/qwat-data-model/pull/365

ponceta commented 2 years ago

@olivierdalang Looks good to me, I've asked a review from oslandia if that's ok for you.

olivierdalang commented 2 years ago

👍

ponceta commented 1 year ago

@olivierdalang Let's get merging?

ponceta commented 1 year ago

thank you @olivierdalang