qwat / qwat-data-model

TEKSI Water module (project QWAT) - PostgreSQL / postgis Datamodel
https://www.teksi.ch
23 stars 24 forks source link

[CI] include pum check in CI to test datamodel upgrades #365

Closed olivierdalang closed 1 year ago

olivierdalang commented 1 year ago

Dependencies

TODO

Notes

I think the tests do work as expected, and highlighted the following issues (which are fixed in this PR):

ponceta commented 1 year ago

https://github.com/qwat/qwat-data-model/pull/363 Should fix qwat_sigip related issues. If not I will be glad to contribute to fix it properly to ensure small customizations are supported.

ponceta commented 1 year ago

@olivierdalang review asked to oslandia if that's ok for you?

olivierdalang commented 1 year ago

@ponceta Yes sure :-)

olivierdalang commented 1 year ago

I think this can be merged provided we're aware of this risk:

I'm not 100% sure this wont cause havoc for those who are not using the latest pum version, since there is a change to migrations files.

For the change in update/delta/delta_1.2.8_schema_visible_perf.pre.py, I guess pum doesn't keep track of its checksum anyway (it's a pre migration), so I think it would not cause issues. If we revert that, we may have silently failing issues.

For the changes in 1.4.0_*, since not release yet, I guess we can consider they are in no one's production database. If we revert that, we loose postgres 9.6 compatibility.

ponceta commented 1 year ago

Thank you @olivierdalang ! We will fix the remaining bug and stuff when they appear.