search

qwat / qwat-data-model

TEKSI Water module (project QWAT) - PostgreSQL / postgis Datamodel
https://www.teksi.ch
23 stars 24 forks source link

[ENH] Put the `geometry` field of the qwat_od.valve table BEFORE all other geometry fields. #380

Open nicolas-sitylb opened 5 months ago

nicolas-sitylb commented 5 months ago

Hello,

What is the purpose of the handle_geometry field in the qwat_od.valve table: https://github.com/qwat/qwat-data-model/blob/d552ec9567a059155d2c1bd78c7425eacc7efbf3/ordinary_data/valve/od_valve.sql#L23 ?

If the geometry field in the qwat_od.valve table is intended to store the real geometry of the features and if the importance of the handle_geometry field is less than the geometry field in this table, I would suggest to place the geometry field BEFORE all other geometry fields.

Why?

Because some software is unfortunately not able to deal with other than the very first geometry column encountered in a PostGIS table. Therefore, as that very first geometry column in the qwat_od.valve table is currently handle_geometry and because it occurs to be empty in most data sets which store the real geometry of features in the geometry column (and because such other software doesn't offer a solution to manually catch the real geometry), I would suggest to put the geometry field BEFORE all other geometry fields in the qwat_od.valve table.

Thanks.

Warm Regards.

ponceta commented 1 month ago

@3nids @tudorbarascu @kandre @tproduit is anyone actively using this handle_geometry attribute?

ponceta commented 1 month ago

@nicolas-sitylb for your information this bother me since day one I got onto QWAT project :

This is my initial issue where you can find interesting workarounds but I think it should be tackled with the next release of QWAT.

https://github.com/qwat/qwat-data-model/issues/265