search

qwazer / markdown-confluence-gradle-plugin

Gradle plugin to publish markdown pages to confluence
Apache License 2.0
12 stars 16 forks source link

Feature/inline images as attachments #21

Closed SimonBerry555 closed 4 years ago

SimonBerry555 commented 4 years ago

Using the 0.9.1 version of the plugin works well - I want any inline images in the document uploaded as attachments to the page.

qwazer commented 4 years ago

commit message "First commit for feature." should be rephrased to provide useful info

qwazer commented 4 years ago

OR squash all commits together

SimonBerry555 commented 4 years ago

Hi - I have addressed all the comments -would you be able to re-review and if OK merge - maybe you could squash the commits so the comment reads: Add feature to process markdown inline images where the target is a file on local filesystem as attachments on the confluence page.

Thanks

SimonBerry555 commented 4 years ago

Hi,

I have made the changes you suggested, could you re-review and if you are happy merge it into the codebase. When you merge you could squash the commits and give a better comment - see my comment on the PR.

Once merged could you do a release of 0.9.2?

Any chance I could be added as a contributor as I have a couple of other things I would like to add?

Thanks

On Mon, 1 Jun 2020 at 14:12, qwazer notifications@github.com wrote:

OR squash all commits together

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/qwazer/markdown-confluence-gradle-plugin/pull/21#issuecomment-636853053, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO24FLK2PFSXPNEB5SWVQETRUOSMNANCNFSM4NM7KYRQ .