search

qwazer / markdown-confluence-gradle-plugin

Gradle plugin to publish markdown pages to confluence
Apache License 2.0
12 stars 16 forks source link

PR for inline images #22

Closed SimonBerry555 closed 4 years ago

SimonBerry555 commented 4 years ago

Hi - I've raised a PR - could you take a look and get back to me please? Thanks

SimonBerry555 commented 4 years ago

Hi,

So to release/publish version 0.9.2 so it is accessible I can follow the steps in how_to_release, I have a few questions if you could answer/confirm the items in bold please?:

  1. Update version in gradle.properties - to 0.9.2
  2. git commit
  3. git tag - tag is v0.9.2
  4. git push - push directly to master? Do I have permission?
  5. wait for upload in bintray from CI build
  6. go to bintray and publish manually - do I need a specific account or can I just use my own?
  7. publish to gradle.portal - please provide details (or link to doc) on how to do this.
  8. update & run test prev_release_availability.gradle- please provide details (or link to doc) on how to do this.

  9. update README https://github.com/qwazer/markdown-confluence-gradle-plugin/blob/master/README.md

    what is required in addition to what I have already added?

Thanks

Simon

On Tue, 2 Jun 2020 at 08:45, qwazer notifications@github.com wrote:

Closed #22 https://github.com/qwazer/markdown-confluence-gradle-plugin/issues/22.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/qwazer/markdown-confluence-gradle-plugin/issues/22#event-3396314230, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO24FLMFLZTHAZXI5J6QUQDRUSU3HANCNFSM4NM7MFQQ .

SimonBerry555 commented 4 years ago

Hi,

I have done steps 1-4, the build seems to be broken in travis:

It seems to be having a problem accessing 0.12.0 of the plugin-publish-plugin even though it is there in https://plugins.gradle.org/m2/ !

Regards

Simon

On Wed, 3 Jun 2020 at 08:16, Simon Berry simon.berry@viooh.com wrote:

Hi,

So to release/publish version 0.9.2 so it is accessible I can follow the steps in how_to_release, I have a few questions if you could answer/confirm the items in bold please?:

  1. Update version in gradle.properties - to 0.9.2
  2. git commit
  3. git tag - tag is v0.9.2
  4. git push - push directly to master? Do I have permission?
  5. wait for upload in bintray from CI build
  6. go to bintray and publish manually - do I need a specific account or can I just use my own?
  7. publish to gradle.portal - please provide details (or link to doc) on how to do this.
  8. update & run test prev_release_availability.gradle- please provide details (or link to doc) on how to do this.
  9. update README https://github.com/qwazer/markdown-confluence-gradle-plugin/blob/master/README.md - what is required in addition to what I have already added?

Thanks

Simon

On Tue, 2 Jun 2020 at 08:45, qwazer notifications@github.com wrote:

Closed #22 https://github.com/qwazer/markdown-confluence-gradle-plugin/issues/22.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/qwazer/markdown-confluence-gradle-plugin/issues/22#event-3396314230, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO24FLMFLZTHAZXI5J6QUQDRUSU3HANCNFSM4NM7MFQQ .

qwazer commented 4 years ago

HI

  1. go to bintray and publish manually - do I need a specific account or can I just use my own?

I will do it under my account on bintray.

  1. publish to gradle.portal - please provide details (or link to doc) on how to do this.

It should be done automatically by build on tag. Maybe manual approve under my account on gradle.portal will be required

  1. update & run test prev_release_availability.gradle- please provide details (or link to doc) on how to do this.

update version (like in https://github.com/qwazer/markdown-confluence-gradle-plugin/commit/9997d9500352b307181677797e20c6d4a198eb6d) uncomment @Ignore on PrevReleaseAvaibilityIT run tests revert changes in PrevReleaseAvaibilityIT (do not commit it)

Note : name of test prev_release_availability.gradle is not perfect. This is place to improve

Thanks for your efforts! Regards

qwazer commented 4 years ago

status update:

6.go to bintray and publish manually

done, fixed by rebuild

  1. publish to gradle.portal

This is pure manual process. done

qwazer commented 4 years ago

issue https://github.com/qwazer/markdown-confluence-gradle-plugin/issues/23 updated to track status