search

qwazer / markdown-confluence-gradle-plugin

Gradle plugin to publish markdown pages to confluence
Apache License 2.0
12 stars 16 forks source link

Added support for authenticating Confluence API calls with Personal Access Tokens (PATs). #37

Closed jigga closed 1 year ago

jigga commented 1 year ago

…ccess Tokens (PATs).

qwazer commented 1 year ago

Hi! Thanks for the PR. Please add new config option to README.md in 2 places: 1) sampe config 2) table with list of options

qwazer commented 1 year ago

Also, just FYI. I'm work on https://github.com/md2conf/md2conf as a new tool to publish stuff to an Confluence.

jigga commented 1 year ago

Thanks for the comments, I've updated the code according to your suggestions. I also added 2 simple tests for verifying the value of the Authorization header sent when making calls to the Confluence APIs.

jigga commented 1 year ago

Also, I will probably switch to using the new tool, however, this will take me some time, and in the meantime, it would be super helpful for me to have the proposed changes integrated and a new version of the plugin published.

qwazer commented 1 year ago

Merged. It's need some infrastructure work to release a new version, since old CI scripts are obsolete.

jigga commented 1 year ago

Thanks vm.

Is there anything I could do on my end to help with the build/release infrastructure? Not really sure how the release/publish process works here, but I could do some research if needed.

Arek

On Tue, Jun 13, 2023 at 8:55 PM qwazer @.***> wrote:

Merged. It's need some infrastructure work to release a new version, since old CI scripts are obsolete.

— Reply to this email directly, view it on GitHub https://github.com/qwazer/markdown-confluence-gradle-plugin/pull/37#issuecomment-1589858170, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACRM26VGRPOK4SSYRMLKNDXLCZQXANCNFSM6AAAAAAZAY2O3A . You are receiving this because you authored the thread.Message ID: @.***>

qwazer commented 1 year ago

Thanks for attempt to help. The main problem is the https://bintray.com/qwazer/maven doesn't accept new packages. Need to switch to maven central for example. Since I'm not user of gradle for several years so priority of this work for me is very low.

So I have 2 options: 1) setup a new package repo for this project. But I'm lazy to do it, to be honest 2) create a new gradle plugin for md2conf/mdconf. It's more attractive for me. I have account for my md2conf/mdconf organization in maven central. But, since I'm not user of gradle... )))

I added you to collaborator of this project. So if you find a replacement of a bintray repo hosting and create the account, setup all stuff for public release - you are welcome.

See https://github.com/qwazer/markdown-confluence-gradle-plugin/blob/master/how-to-release.md

I have access to https://plugins.gradle.org/ so I can do final publishing in plugins.gradle.org

jigga commented 1 year ago

Hey,

Do we even need to publish it to Maven Central?

I think that if we only publish it to Gradle's plugin portal it should be available to use by anyone interested in the plugin.

Gradle's users typically use a separate repo for the plugins, so honestly I don't see any real benefit of publishing to to Maven Central.

What do you think?

BTW, I did the initial release ceremony (updated gradle.properties, tagged and pushed).

Arek

On Thu, Jun 15, 2023 at 12:43 AM qwazer @.***> wrote:

Thanks for attempt to help. The main problem is the https://bintray.com/qwazer/maven doesn't accept new packages. Need to switch to maven central for example. Since I'm not user of gradle for several years so priority of this work for me is very low.

So I have 2 options:

  1. setup a new package repo for this project. But I'm lazy to do it, to be honest
  2. create a new gradle plugin for md2conf/mdconf. It's more attractive for me. I have account for my md2conf/mdconf organization in maven central. But, since I'm not user of gradle... )))

I added you to collaborator of this project. So if you find a replacement of a bintray repo hosting and create the account, setup all stuff for public release - you are welcome.

See https://github.com/qwazer/markdown-confluence-gradle-plugin/blob/master/how-to-release.md

I have access to https://plugins.gradle.org/ so I can do final publishing in plugins.gradle.org

— Reply to this email directly, view it on GitHub https://github.com/qwazer/markdown-confluence-gradle-plugin/pull/37#issuecomment-1592087903, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACRM2Z6KUYJK2VO4K2ROODXLI47VANCNFSM6AAAAAAZAY2O3A . You are receiving this because you authored the thread.Message ID: @.***>

jigga commented 1 year ago

Hi,

Could you help publish the new version of the plugin to the Gradle plugin portal?

The group id is managed by your account, and hence I cannot publish it myself.

I already raised the ticket to also publish it to the Central ( https://issues.sonatype.org/browse/OSSRH-92586), however, I'm not sure how long it will take, and having it in the Gradle's plugin portal would help me tremendously.

Thanks , Arek

On Fri, Jun 16, 2023 at 4:49 PM Arkadiusz Gasiński @.***> wrote:

Hey,

Do we even need to publish it to Maven Central?

I think that if we only publish it to Gradle's plugin portal it should be available to use by anyone interested in the plugin.

Gradle's users typically use a separate repo for the plugins, so honestly I don't see any real benefit of publishing to to Maven Central.

What do you think?

BTW, I did the initial release ceremony (updated gradle.properties, tagged and pushed).

Arek

On Thu, Jun 15, 2023 at 12:43 AM qwazer @.***> wrote:

Thanks for attempt to help. The main problem is the https://bintray.com/qwazer/maven doesn't accept new packages. Need to switch to maven central for example. Since I'm not user of gradle for several years so priority of this work for me is very low.

So I have 2 options:

  1. setup a new package repo for this project. But I'm lazy to do it, to be honest
  2. create a new gradle plugin for md2conf/mdconf. It's more attractive for me. I have account for my md2conf/mdconf organization in maven central. But, since I'm not user of gradle... )))

I added you to collaborator of this project. So if you find a replacement of a bintray repo hosting and create the account, setup all stuff for public release - you are welcome.

See https://github.com/qwazer/markdown-confluence-gradle-plugin/blob/master/how-to-release.md

I have access to https://plugins.gradle.org/ so I can do final publishing in plugins.gradle.org

— Reply to this email directly, view it on GitHub https://github.com/qwazer/markdown-confluence-gradle-plugin/pull/37#issuecomment-1592087903, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACRM2Z6KUYJK2VO4K2ROODXLI47VANCNFSM6AAAAAAZAY2O3A . You are receiving this because you authored the thread.Message ID: @.***>

jigga commented 1 year ago

Hi,

Yet another follow-up, namely:

Invalid groupId, com.github. Group IDs are invalid now. The only allowed groupIds for Github projects are io.github.**

io.github.qwazer would be valid based on your Project URL.

To continue the registration process, please follow these steps:

  1. Create a temporary, public repository called https://github.com/qwazer/OSSRH-92586 to verify github account ownership.
    1. Edit this ticket, update the Group ID field with the new GroupId, and set Status to Open.

More info: https://central.sonatype.org/publish/requirements/coordinates/

Could you create the public repo under your account to confirm account ownership?

Thanks!

On Mon, Jun 19, 2023 at 9:20 AM Arkadiusz Gasiński @.***> wrote:

Hi,

Could you help publish the new version of the plugin to the Gradle plugin portal?

The group id is managed by your account, and hence I cannot publish it myself.

I already raised the ticket to also publish it to the Central ( https://issues.sonatype.org/browse/OSSRH-92586), however, I'm not sure how long it will take, and having it in the Gradle's plugin portal would help me tremendously.

Thanks , Arek

On Fri, Jun 16, 2023 at 4:49 PM Arkadiusz Gasiński @.***> wrote:

Hey,

Do we even need to publish it to Maven Central?

I think that if we only publish it to Gradle's plugin portal it should be available to use by anyone interested in the plugin.

Gradle's users typically use a separate repo for the plugins, so honestly I don't see any real benefit of publishing to to Maven Central.

What do you think?

BTW, I did the initial release ceremony (updated gradle.properties, tagged and pushed).

Arek

On Thu, Jun 15, 2023 at 12:43 AM qwazer @.***> wrote:

Thanks for attempt to help. The main problem is the https://bintray.com/qwazer/maven doesn't accept new packages. Need to switch to maven central for example. Since I'm not user of gradle for several years so priority of this work for me is very low.

So I have 2 options:

  1. setup a new package repo for this project. But I'm lazy to do it, to be honest
  2. create a new gradle plugin for md2conf/mdconf. It's more attractive for me. I have account for my md2conf/mdconf organization in maven central. But, since I'm not user of gradle... )))

I added you to collaborator of this project. So if you find a replacement of a bintray repo hosting and create the account, setup all stuff for public release - you are welcome.

See https://github.com/qwazer/markdown-confluence-gradle-plugin/blob/master/how-to-release.md

I have access to https://plugins.gradle.org/ so I can do final publishing in plugins.gradle.org

— Reply to this email directly, view it on GitHub https://github.com/qwazer/markdown-confluence-gradle-plugin/pull/37#issuecomment-1592087903, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACRM2Z6KUYJK2VO4K2ROODXLI47VANCNFSM6AAAAAAZAY2O3A . You are receiving this because you authored the thread.Message ID: @.*** com>

jigga commented 1 year ago

Hi qwazer,

Any chance you'd be able to help with this?

Or shall I publish it under a different group id?

Thanks, Arek

On Mon, Jun 19, 2023 at 12:46 PM Arkadiusz Gasiński @.***> wrote:

Hi,

Yet another follow-up, namely:

Invalid groupId, com.github. Group IDs are invalid now. The only allowed groupIds for Github projects are io.github.**

io.github.qwazer would be valid based on your Project URL.

To continue the registration process, please follow these steps:

  1. Create a temporary, public repository called https://github.com/qwazer/OSSRH-92586 to verify github account ownership.
    1. Edit this ticket, update the Group ID field with the new GroupId, and set Status to Open.

More info: https://central.sonatype.org/publish/requirements/coordinates/

Could you create the public repo under your account to confirm account ownership?

Thanks!

On Mon, Jun 19, 2023 at 9:20 AM Arkadiusz Gasiński @.***> wrote:

Hi,

Could you help publish the new version of the plugin to the Gradle plugin portal?

The group id is managed by your account, and hence I cannot publish it myself.

I already raised the ticket to also publish it to the Central ( https://issues.sonatype.org/browse/OSSRH-92586), however, I'm not sure how long it will take, and having it in the Gradle's plugin portal would help me tremendously.

Thanks , Arek

On Fri, Jun 16, 2023 at 4:49 PM Arkadiusz Gasiński @.***> wrote:

Hey,

Do we even need to publish it to Maven Central?

I think that if we only publish it to Gradle's plugin portal it should be available to use by anyone interested in the plugin.

Gradle's users typically use a separate repo for the plugins, so honestly I don't see any real benefit of publishing to to Maven Central.

What do you think?

BTW, I did the initial release ceremony (updated gradle.properties, tagged and pushed).

Arek

On Thu, Jun 15, 2023 at 12:43 AM qwazer @.***> wrote:

Thanks for attempt to help. The main problem is the https://bintray.com/qwazer/maven doesn't accept new packages. Need to switch to maven central for example. Since I'm not user of gradle for several years so priority of this work for me is very low.

So I have 2 options:

  1. setup a new package repo for this project. But I'm lazy to do it, to be honest
  2. create a new gradle plugin for md2conf/mdconf. It's more attractive for me. I have account for my md2conf/mdconf organization in maven central. But, since I'm not user of gradle... )))

I added you to collaborator of this project. So if you find a replacement of a bintray repo hosting and create the account, setup all stuff for public release - you are welcome.

See https://github.com/qwazer/markdown-confluence-gradle-plugin/blob/master/how-to-release.md

I have access to https://plugins.gradle.org/ so I can do final publishing in plugins.gradle.org

— Reply to this email directly, view it on GitHub https://github.com/qwazer/markdown-confluence-gradle-plugin/pull/37#issuecomment-1592087903, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACRM2Z6KUYJK2VO4K2ROODXLI47VANCNFSM6AAAAAAZAY2O3A . You are receiving this because you authored the thread.Message ID: @.*** com>

qwazer commented 1 year ago

Hi Sorry for delay in answers

I created https://github.com/qwazer/OSSRH-92586

I see 2 basic options here 1) continue with maven central and renaming to io.github.qwazer namespace 2) publish to any maven repo. I think "github-packages-registry" fit these needs. But need research. https://docs.github.com/en/packages/working-with-a-github-packages-registry

I vote for number 2.

qwazer commented 1 year ago

Looks like 2 is not the option, because is useless because clients cannot download artifacts from Github Package Registry without authorization

qwazer commented 1 year ago

The next first googled alternative to bintray is https://jitpack.io/

qwazer commented 1 year ago

@jigga released. Please check!

jigga commented 1 year ago

Awesome, thanks very much for your help with this.

I checked, new version is available. Will verify that the changes work in the wild and will come back with an update.

Arek

On Wed, Jun 21, 2023 at 9:29 AM qwazer @.***> wrote:

@jigga https://github.com/jigga released. Please check!

— Reply to this email directly, view it on GitHub https://github.com/qwazer/markdown-confluence-gradle-plugin/pull/37#issuecomment-1600325449, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACRM22AI2FSJ2FNEDWLYDTXMKPFFANCNFSM6AAAAAAZAY2O3A . You are receiving this because you were mentioned.Message ID: @.***>