search

qwefgh90 / ng-terminal

NgTerminal is a terminal component on Angular. the Ivy distribution's been released from v5.0.0.
https://qwefgh90.github.io/ng-terminal/
Other
125 stars 27 forks source link

Fix resize bug by updating xterm-addon-fit #72

Closed z0rb closed 1 year ago

z0rb commented 1 year ago

Hi,

I had issues resizing the terminal after updating ng-terminal to the latest version. After a long while I found the bug responsible for it: https://github.com/xtermjs/xterm.js/issues/4344

After updating xterm-addon-fit to 0.7.0, ng-terminal resized properly again. Can you upgrade the dependency so everyone gets the fix?

qwefgh90 commented 1 year ago

Hello.

Thank you for letting me know the issue. I made a commit to bump up the xterm-addon-fit version to 0.7.0 and published new release 5.5.0.

I'm not sure new release's working well. If you need any support, please make a comment.

z0rb commented 1 year ago

Thanks! I removed the dependency override and tested with the new version, all good.