search

qwersyk / Newelle

Newelle - Your Ultimate Virtual Assistant
https://flathub.org/apps/io.github.qwersyk.Newelle
GNU General Public License v3.0
155 stars 19 forks source link

Newelle will enter a command run loop without showing the other text within a message. #102

Open Galexion opened 1 hour ago

Galexion commented 1 hour ago

glxn@GLXN-RoadWarrior OS: EndeavourOS Linux x8 Host: MacBookAir5,2 1.0 Kernel: 6.11.9-arch1-1 DE: Hyprland

Version: 0.4.1 Acquired by: Flatpak

I found that Newelle will enter a Spiral if Auto-Run Commands is enabled.

After using the user prompt Please tell me what is in my hyprland configuration using this option, Newelle found itself in a loop on multiple attempts of this prompt, where it would keep suggesting commands at the beginning or end of a message, and Newelle would clear out everything but the command widget out, without giving the user the chance to see what it had typed out beforehand, leaving the user clueless on what Newelle is actually doing.

Personally I think this feature should have a user settable limit, and if this is not implemented already, that Newelle checks for potentially destructive commands anyways and confirms with the user, and no matter what, it always shows what It's saying. Having the user clueless and potentially frustrated about what it's doing can be disastrous in certain situations, and should be avoided.

FrancescoCaracciolo commented 1 hour ago

I don't really understand what actually happened in the first paragraph.

There are already some commands excluded from Auto Run: https://github.com/qwersyk/Newelle/blob/7ed025c7f28089c7fd78c789fa32ce63eec8372c/src/window.py#L1145

I will do some investigation about it, I haven't tested auto run much personally

Galexion commented 1 hour ago

https://github.com/user-attachments/assets/68fa3548-6cf1-499e-b967-26e07da593e0

Took me a hot second to get OBS to work on Hyprland but I've decided to record and upload a video of what is happening on my end to better illustrate what is going on.

FrancescoCaracciolo commented 1 hour ago

Ok thank you. I will check and try to find a solution. In general I strongly suggest you to disable auto run because the LLM might come up with terrible commands