search

qwikerx / flowbite-qwik

Official Qwik components built for Flowbite and Tailwind CSS
https://flowbite-qwik.com
MIT License
36 stars 2 forks source link

Unable to set font size on <Input/> #208

Closed genox closed 1 week ago

genox commented 1 week ago

Hi,

When trying to make a large Input field using size="lg" I would like to adjust the font-size as well. Using class="text-lg" on the Input has no effect because the actual element has text-sm applied, which takes precedence over the class on the parent. There seems to be also no easy way to target the input directly using arbitrary selectors.

I think either an exposed text-size attribute on the component or a theme option would be nice.

Best regards!

xmimiex commented 1 week ago

Hi @genox, yes I will add a "theme" option, I'll keep you informed.

xmimiex commented 1 week ago

Hey @genox , latest version fixes this issue, v0.37.8

genox commented 1 week ago

Thank you, I've seen the commit. I discovered an issue win my PR that I made recently, I will push a fix for that too.

xmimiex commented 1 week ago

I think we have fixed your discovered issue, you can test before with the latest version.

Documentation for modular-forms : https://flowbite-qwik.com/docs/forms/input#modular-forms

genox commented 1 week ago

I noticed that input in some cases didn't fire onChange$ or did so with a huge delay.

I also noticed that my typing of those qwik attributes was wrong. I will check if this is changed or make a PR.

genox commented 1 week ago

After your revert, my form no longer receives change events and the data is not logged in the formAction$ anymore.

I guess this also depends on the complexity of the form, as well as how deeply nested the form is. Otherwise I can't explain this behaviour. The only thing that helped for me was to not spread props that contain qwik events or signals.