qwikifiers / qwik-nx

Nx plugin for Qwik
130 stars 23 forks source link

fix(qwik-nx): get canonical url from the right path #138

Closed wtlin1228 closed 1 year ago

wtlin1228 commented 1 year ago

What is it?

Description

useLocation() returns us a RouteLocation instance. So we should get the href from loc.url.href.

export declare interface RouteLocation {
    readonly params: Readonly<Record<string, string>>;
    readonly url: URL;
    readonly isNavigating: boolean;
}

Use cases and why

Screenshots/Demo

Checklist:

nx-cloud[bot] commented 1 year ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f936bfbb27ae2e9b2ee6b4d50b66bdec3f9c2108. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 8 targets - [`nx affected --target=e2e --base=last-release`](https://cloud.nx.app/runs/H5FlfpYGO9) - [`nx affected --target=e2e --base=last-release`](https://cloud.nx.app/runs/oAbhY94snH) - [`nx affected --target=test --base=last-release`](https://cloud.nx.app/runs/sIhFwWCjgK) - [`nx affected:build --base=last-release --exclude=add-nx-to-qwik`](https://cloud.nx.app/runs/JDSrS6Lle2) - [`nx affected:lint --base=last-release --exclude=add-nx-to-qwik`](https://cloud.nx.app/runs/Dbrbivs6JN) - [`nx affected --target=test --base=last-release`](https://cloud.nx.app/runs/fE3urSdb69) - [`nx affected:build --base=last-release --exclude=add-nx-to-qwik`](https://cloud.nx.app/runs/fYrrSfD41L) - [`nx affected:lint --base=last-release --exclude=add-nx-to-qwik`](https://cloud.nx.app/runs/mFBZ186RKF)

Sent with 💌 from NxCloud.

dmitry-stepanenko commented 1 year ago

Thanks for catching this!