qwikifiers / qwik-nx

Nx plugin for Qwik
131 stars 24 forks source link

bug:? qwik-nx doesn't appear to be written in CJS #14

Closed reemardelarosa closed 1 year ago

reemardelarosa commented 1 year ago

Describe the bug

qwik-nx doesn't appear to be written in CJS, but also doesn't appear to be a valid ES module (i.e. it doesn't have "type": "module" or an .mjs extension for the entry point). Please contact the package author to fix.
11:29:29 AM [vite] warning: Parsing error: ESLint was configured to run on `<tsconfigRootDir>/src/root.tsx` using `parserOptions.project`: <tsconfigRootDir>/../../../../../../../../users/johnreemardelarosa/reezen/training/nx/nx-org/packages/qwik-app/tsconfig.json
However, that TSConfig does not include this file. Either:
- Change ESLint's list of included files to not include this file
- Change that TSConfig to include this file
- Create a new TSConfig that includes this file and include it in your parserOptions.project
See the TypeScript ESLint docs for more info: https://typescript-eslint.io/linting/troubleshooting##i-get-errors-telling-me-eslint-was-configured-to-run--however-that-tsconfig-does-not--none-of-those-tsconfigs-include-this-file
  Plugin: vite-plugin-qwik
  File: /Users/johnreemardelarosa/REEZEN/TRAINING/NX/nx-org/packages/qwik-app/src/root.tsx:undefined:undefined
11:29:30 AM [vite] warning: Parsing error: ESLint was configured to run on `<tsconfigRootDir>/src/components/icons/qwik.tsx` using `parserOptions.project`: <tsconfigRootDir>/../../../../../../../../users/johnreemardelarosa/reezen/training/nx/nx-org/packages/qwik-app/tsconfig.json
However, that TSConfig does not include this file. Either:
- Change ESLint's list of included files to not include this file
- Change that TSConfig to include this file
- Create a new TSConfig that includes this file and include it in your parserOptions.project
See the TypeScript ESLint docs for more info: https://typescript-eslint.io/linting/troubleshooting##i-get-errors-telling-me-eslint-was-configured-to-run--however-that-tsconfig-does-not--none-of-those-tsconfigs-include-this-file
  Plugin: vite-plugin-qwik
  File: /Users/johnreemardelarosa/REEZEN/TRAINING/NX/nx-org/packages/qwik-app/src/components/icons/qwik.tsx:undefined:undefined

To Reproduce Steps to reproduce the behavior:

  1. create nxworkspace
  2. install qwik-nx
  3. nx generate qwik-nx:app
  4. nx serve qwik-app
  5. See error in terminal

Expected behavior No warning in terminal when running qwik app via nx serve

Screenshots If applicable, add screenshots to help explain your problem.

Screenshot 2022-12-10 at 12 50 09 PM

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

dmitry-stepanenko commented 1 year ago

@reemardelarosa can you confirm this is still reproducible?

reemardelarosa commented 1 year ago

@dmitry-stepanenko unable to test because of > NX Cannot find module '@nxkit/playwright'

dmitry-stepanenko commented 1 year ago

@reemardelarosa there's a pending PR to fix this. As of now, you can use --e2eTestRunner=none when creating the repo: npx create-nx-workspace@latest --preset=qwik-nx --e2eTestRunner=none

reemardelarosa commented 1 year ago

@dmitry-stepanenko this is now fixed. Thanks!

cc: @shairez