search

qwikifiers / qwik-nx

Nx plugin for Qwik
130 stars 23 forks source link

nested folders do not play well with playwright e2e generator #153

Closed dmitry-stepanenko closed 1 year ago

dmitry-stepanenko commented 1 year ago

Project name will be incorrectly resolved if nested directory is provided. Most likely this is something to address in the playwright generator

dmitry-stepanenko commented 1 year ago

@sebastiandg7 FYI. If you have a chance to look into it, will be awesome. Otherwise I'll try to fix it a bit later.

For context: it turned out that qwik-nx wasn't handling "directory" option in the same way as Nx does https://github.com/nrwl/nx/commit/fe062f42c366e9ed734208f5feaa1c623f696b67. I have fixed all implementations in qwik-nx here https://github.com/qwikifiers/qwik-nx/pull/152

Ideally we have to enable same tests with "playwright" option without any additional changes https://github.com/qwikifiers/qwik-nx/blob/324f81c34612f19383e470f891b86548cfa2d25b/packages/qwik-nx/src/generators/e2e-project/generator.spec.ts#L56

sebastiandg7 commented 1 year ago

I'll take a look at that. Will let you know once the fix is released.

dmitry-stepanenko commented 1 year ago

Thanks a lot!

sebastiandg7 commented 1 year ago

@dmitry-stepanenko It took a little while! 😅 Fixing in nxkit/nxkit#88.

sebastiandg7 commented 1 year ago

@nxkit/playwright v3.0.2 released containing the fix 🚀

dmitry-stepanenko commented 1 year ago

Awesome, thanks a lot @sebastiandg7 !

dmitry-stepanenko commented 1 year ago

resolved by https://github.com/qwikifiers/qwik-nx/pull/173