search

qwikifiers / qwik-nx

Nx plugin for Qwik
131 stars 24 forks source link

Cloudflare generator is using an old configuration and has some typos #174

Closed NachoVazquez closed 1 year ago

NachoVazquez commented 1 year ago

Current Behavior

When running the Cloudflare adapter generator

nx generate qwik-nx:cloudflare-pages-integration <app-name>

we have a couple of issues:

  1. The cloudflarePagesAdapter is misspelled as cloudflarePagesAdaptor
  2. The staticGenerate: true options doesn't exists anymore

Expected Behavior

The generated configuration should be correct

GitHub Repo

No response

Steps to Reproduce

  1. Generate a new qwik-nx application a. npx create-qwik-nx@latest b. nx generate qwik-nx:app
  2. Add the Cloudflare adapter using the generator a. nx generate qwik-nx:cloudflare-pages-integration <app-name>
  3. Go to the adapters/cloudflare-pages/vite.config.ts and try to build with nx build <app-name>

Nx Report

Node   : 16.19.0
   OS     : darwin arm64
   pnpm   : 8.2.0
   Hasher : Native

   nx                 : 16.3.1
   @nx/js             : 16.3.2
   @nx/linter         : 16.3.1
   @nx/workspace      : 16.3.1
   @nx/eslint-plugin  : 16.3.1
   @nx/react          : 16.3.2
   @nx/vite           : 16.3.2
   nx-cloud           : 16.0.5
   typescript         : 5.0.2
   ---------------------------------------
   Community plugins:
   @k11r/nx-cloudflare-wrangler : 2.0.0
   qwik-nx                      : 1.0.4
   ---------------------------------------
   The following packages should match the installed version of nx
     - @nx/js@16.3.2
     - @nx/react@16.3.2
     - @nx/vite@16.3.2

   To fix this, run `nx migrate nx@16.3.2`

Failure Logs

No response

Additional Information

No response