qwikifiers / qwik-nx

Nx plugin for Qwik
131 stars 24 forks source link

fix: vite.config for cloudflare adapter miss-configurations #175

Closed NachoVazquez closed 1 year ago

NachoVazquez commented 1 year ago

What is it?

Description

The generator for Cloudflare had a couple of problems with the adapter vite.config.ts file. These are the changes made.

Fixes: #174

Use cases and why

Actual Behavior

The generated content has issues. and not allowed to build the apps.

Expected Behavior

The generated content is correct and allows to build and deploy to Cloudflare.

Checklist:

nx-cloud[bot] commented 1 year ago

☁️ Nx Cloud Report

Attention: This version of the Nx Cloud GitHub bot will cease to function on July 1st, 2023. An organization admin can update your integration here.

CI is running/has finished running commands for commit 388d245173486d3943ecb9561ab22ebb758378ef. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 8 targets - [`nx affected --target=e2e --base=3def6577def2738be5399f68f78b434db52a82fc --head=HEAD`](https://cloud.nx.app/runs/D9xoeGcKSk) - [`nx affected --target=e2e --base=3def6577def2738be5399f68f78b434db52a82fc --head=HEAD`](https://cloud.nx.app/runs/BHOUIxzY7o) - [`nx affected --target=test --base=3def6577def2738be5399f68f78b434db52a82fc --head=HEAD`](https://cloud.nx.app/runs/0brnvyq83n) - [`nx affected:build --base=3def6577def2738be5399f68f78b434db52a82fc --head=HEAD --exclude=add-nx-to-qwik`](https://cloud.nx.app/runs/1LKySzkm58) - [`nx affected:lint --base=3def6577def2738be5399f68f78b434db52a82fc --head=HEAD --exclude=add-nx-to-qwik`](https://cloud.nx.app/runs/3weamPXBNK) - [`nx affected --target=test --base=3def6577def2738be5399f68f78b434db52a82fc --head=HEAD`](https://cloud.nx.app/runs/qj3IHDp08l) - [`nx affected:build --base=3def6577def2738be5399f68f78b434db52a82fc --head=HEAD --exclude=add-nx-to-qwik`](https://cloud.nx.app/runs/Rw85hxmdba) - [`nx affected:lint --base=3def6577def2738be5399f68f78b434db52a82fc --head=HEAD --exclude=add-nx-to-qwik`](https://cloud.nx.app/runs/MdGTBmerl2)

Sent with 💌 from NxCloud.

BleedingDev commented 1 year ago

Looking forward to this one! :)

dmitry-stepanenko commented 1 year ago

@all-contributors please add @NachoVazquez for code, ideas, tests, docs

allcontributors[bot] commented 1 year ago

@dmitry-stepanenko

I've put up a pull request to add @NachoVazquez! :tada: