search

qwikifiers / qwik-nx

Nx plugin for Qwik
130 stars 23 forks source link

replace default port #195

Closed JulianTurner closed 9 months ago

JulianTurner commented 10 months ago

What is it?

Description

Changed the default Port from 4200 to 5173

121

dmitry-stepanenko commented 10 months ago

Hey @JulianTurner, thank you for the PR! Do you mind also switching the preview port from 4300 to 4173 https://github.com/qwikifiers/qwik-nx/blob/main/packages/qwik-nx/src/generators/application/utils/normalize-options.ts#L53 ?

JulianTurner commented 10 months ago

Hey @JulianTurner, thank you for the PR! Do you mind also switching the preview port from 4300 to 4173 https://github.com/qwikifiers/qwik-nx/blob/main/packages/qwik-nx/src/generators/application/utils/normalize-options.ts#L53 ?

Sure, I just pushed a update

dmitry-stepanenko commented 10 months ago

Hey @JulianTurner, thank you for the PR! Do you mind also switching the preview port from 4300 to 4173 https://github.com/qwikifiers/qwik-nx/blob/main/packages/qwik-nx/src/generators/application/utils/normalize-options.ts#L53 ?

Sure, I just pushed a update

thanks a lot! looks like you also have to run nx run qwik-nx:test -u in order to update snapshots, because CI is failing

JulianTurner commented 10 months ago

Hey @JulianTurner, thank you for the PR! Do you mind also switching the preview port from 4300 to 4173 https://github.com/qwikifiers/qwik-nx/blob/main/packages/qwik-nx/src/generators/application/utils/normalize-options.ts#L53 ?

Sure, I just pushed a update

thanks a lot! looks like you also have to run nx run qwik-nx:test -u in order to update snapshots, because CI is failing

Thanks for the insight, this is running now :-)

JulianTurner commented 9 months ago

@dmitry-stepanenko Updated as mentioned

dmitry-stepanenko commented 9 months ago

yay, merged 🎉 thanks for this!

JulianTurner commented 9 months ago

Thank you