qwikifiers / qwik-nx

Nx plugin for Qwik
130 stars 23 forks source link

Debugging/inspecting with Modular Forms gives qwik-city-plan errors #206

Open intellix opened 8 months ago

intellix commented 8 months ago

Current Behavior

If you create a brand new qwik-nx project, install modular forms and try to debug/inspect locally, you'll get an error about and invalid qwik-city-plan module:

Invalid module "@qwik-city-plan" is not a valid package name imported from /Projects/myapp/node_modules/@builder.io/qwik-city/index.qwik.mjs

Originally I wrote about it here: https://github.com/BuilderIO/qwik/issues/3297#issuecomment-1741789593

Expected Behavior

You should just be able to debug locally

GitHub Repo

No response

Steps to Reproduce

  1. Create a brand new qwik-nx project

  2. Install modular-forms:

    npm i @modular-forms/qwik
  3. Add this to header.tsx in the new project:

    
    import { useForm } from '@modular-forms/qwik';

const loader = useSignal({ email: '' }); useForm<any, any>({ loader, validateOn: 'change' });


4 Run the debug preview:

npx nx run myapp:serve.debug


### Nx Report

```shell
Node   : 18.16.0
   OS     : darwin arm64
   npm    : 9.5.1
   Hasher : Native

   nx                 : 16.2.2
   @nx/js             : 16.2.2
   @nx/linter         : 16.2.2
   @nx/workspace      : 16.2.2
   @nx/cypress        : 16.2.2
   @nx/devkit         : 16.2.2
   @nx/eslint-plugin  : 16.2.2
   @nx/storybook      : 16.2.2
   @nrwl/tao          : 16.2.2
   @nx/vite           : 16.2.2
   typescript         : 5.1.6
   ---------------------------------------
   Community plugins:
   qwik-nx : 1.0.11

Failure Logs

Invalid module "@qwik-city-plan" is not a valid package name imported from /Projects/myapp/node_modules/@builder.io/qwik-city/index.qwik.mjs

Additional Information

It's the exact same command being run with a brand new qwik project and I noticed that it works there without issue.

gNaps commented 7 months ago

I don't know why but using pnpm instead of yarn resolved for me.

gnemanja commented 6 months ago

@intellix Did you manage to solve this issue? Thank You in advance

intellix commented 6 months ago

nope, I was hoping that this work actually helps here though, but not sure: https://github.com/qwikifiers/qwik-nx/pull/218