search

qwikifiers / qwik-nx

Nx plugin for Qwik
130 stars 23 forks source link

chore: fix local package publishing #84

Closed dmitry-stepanenko closed 1 year ago

dmitry-stepanenko commented 1 year ago

Right now the description of local publishing is completely irrelevant, it's not possible to run it in the way it is described in our docs.

Additionally to this working with verdaccio might not be that straightforward, because it is needed to explicitly specify what registry to pull from, how to clean it and so on.

Instead of this it might be better to use the same approach Nx team has in their repository: the bash script that will allow to run few plain commands to start/stop/clean the local registry.

Publishing process itself is also improved: prior to this PR I have created a pull to ngx-deploy-npm adding the registry option. With this in place, starting from ngx-deploy-npm@5.2.0 it is now possible to publish to another registry using nx target configuration (nx run qwik-nx:publish:local in our case)

shairez commented 1 year ago

can you write more context for this PR please?

thanks 🙏

dmitry-stepanenko commented 1 year ago

@shairez updated the description 🙂

shairez commented 1 year ago

great job @dmitry-stepanenko ! 👏