qwikifiers / qwik-ui

Qwik's official Headless and styled component library
https://qwikui.com
MIT License
605 stars 135 forks source link

Prefer "class" over "className" #108

Closed GregOnNet closed 1 year ago

GregOnNet commented 1 year ago

Reproduction

cd packages/website
npm start
CleanShot 2023-01-29 at 21 23 20@2x

Proposed solution

We might want to replace className with class.

Final thoughts

shairez commented 1 year ago

thanks @GregOnNet ! go for it! 💪🙏

GregOnNet commented 1 year ago

I encounter an error executing npx nx storybook core (stated in contribution guideline). I am using Node 18.

image

So I executed npx sb@next automigrate like stated in the error. This ran the following migrations:

After the migration storybook does not start.

image

GregOnNet commented 1 year ago

So I verified that my change does not break anything by:

cd packages/website
npm start # clicking through the components 🤗
Balastrong commented 1 year ago

I see there are no more className props in the project, maybe we can close this issue? cc @gioboa

gioboa commented 1 year ago

Yes, thanks.