qwikifiers / qwik-ui

Qwik's official Headless and styled component library
https://qwikui.com
MIT License
570 stars 116 forks source link

Feat/242 add input phone #243

Closed tleperou closed 1 year ago

tleperou commented 1 year ago

What is it?

Description

Input Phone aims at formatting and validating with ease international phone number.

In details

  1. automatic detection of country code from phone number input
  2. manual country code from select
  3. validate: 'INVALID_COUNTRY' | 'NOT_A_NUMBER' | 'TOO_SHORT' | 'TOO_LONG' | 'INVALID_LENGTH' | 'MAYBE_VALID' | 'NOT_VALID' | 'VALID'

Accessibility

Note: Shall integrate the headless Select, maybe when the autocompletion is implemented + Axe tested.

Use cases and why

Any where a phone number is required

Screenshots/Demo

image image

Checklist:

github-actions[bot] commented 1 year ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

tleperou commented 1 year ago

Accessibility test with Axe

image

image

gioboa commented 1 year ago

That's great. Can you describe how to test the component with axe please? You can add the steps here CODING_STANDARDS.md

tleperou commented 1 year ago

I have read the CLA Document and I hereby sign the CLA

tleperou commented 1 year ago

@gioboa, I proceed with the code standard updates in a separate MR, #244.

Shall tests results be associated within the component, somehow ?

gioboa commented 1 year ago

a11y need to be documented so I think we can create a markdown with our components + axe screenshots

tleperou commented 1 year ago

!245 for the coding standard.

I mentioned the way to store test reports: in Github or discord (temporarily).

I better dig further within the extension to see how to extract the report and collocate it nicely with the component

tleperou commented 1 year ago

a11y need to be documented so I think we can create a markdown with our components + axe screenshots

Added in a .json format.

The structure result refers to the language. It seemed to me be not enough relevant to the component's scope to fix the issues of the structure.