qwikifiers / qwik-ui

Qwik's official Headless and styled component library

https://qwikui.com

MIT License

558 stars 115 forks source link

first pass #686

Closed b4thestorm closed 1 month ago

b4thestorm commented 1 month ago

What is it?

[ ] Feature / enhancement
[x] Bug
[ ] Docs / tests
[ ] Other

Why is it needed?

This is a first pass at making the copy button work on Styled doc's pages. Currently, markdown is trying to render code snippets but is not able to pass code to js clipboard function.

Checklist:

[ ] My code follows the developer guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have ran pnpm change and documented my changes
[ ] I have add necessary docs (if needed)
[ ] Added new tests to cover the fix / functionality

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 66d26fee27de53023fbba24b4755ae38b6fbda97

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions[bot] commented 1 month ago

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

_{You can retrigger this bot by commenting recheck in this Pull Request}

maiieul commented 1 month ago

Thanks for giving this a try. Using CodeSnippet instead of markdown code blocks is a good workaround, although I would prefer this to be fixed for real. The underlying issue either comes from mdx-components or from the website vite-config rehype plugin code.

b4thestorm commented 1 month ago

Thanks for giving this a try. Using CodeSnippet instead of markdown code blocks is a good workaround, although I would prefer this to be fixed for real. The underlying issue either comes from mdx-components or from the website vite-config rehype plugin code.

Thanks @maiieul. I was reading an issue where that was mentioned: https://github.com/qwikifiers/qwik-ui/issues/660

im going to delete my PR and try to debug and see if I can get my head around the mdx component and how it’s read in.