qwikifiers / qwik-ui

Qwik's official Headless and styled component library
https://qwikui.com
MIT License
558 stars 115 forks source link

docs: modal: change onHide to onClose #706

Closed Wykks closed 1 month ago

Wykks commented 1 month ago

What is it?

Why is it needed?

Modal event hook is onClose not onHide anymore

Checklist:

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 3bcfd6047c59b0350654b30000b7d980e0c2efad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions[bot] commented 1 month ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Wykks commented 1 month ago

I have read the CLA Document and I hereby sign the CLA

Wykks commented 1 month ago

recheck

thejackshelton commented 1 month ago

LGTM! Merged. Thank you for the PR @Wykks