qwikifiers / qwik-ui

Qwik's official Headless and styled component library

https://qwikui.com

MIT License

558 stars 115 forks source link

feat: Add Chrome 113 testing to ensure backwards compatibility #720

Closed cwoolum closed 2 weeks ago

cwoolum commented 3 weeks ago

What is it?

This PR add the ability to test with Chrome 113. I have tested it in Windows and Linux.

Linux

Windows

When running the command nx run headless:e2e-chrome-113 --ui, a script will run that downloads Chrome 113 for the appropriate OS the developer is using.

[x] Feature / enhancement
[ ] Bug
[ ] Docs / tests
[ ] Other

Checklist:

[x] My code follows the developer guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have ran pnpm change and documented my changes
[ ] I have add necessary docs (if needed)
[ ] Added new tests to cover the fix / functionality

changeset-bot[bot] commented 3 weeks ago

⚠️ No Changeset found

Latest commit: 269fb57eb80cff1e4f385139eb205b130f37974e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

cwoolum commented 3 weeks ago

https://github.com/qwikifiers/qwik-ui-polyfill-browsers/pull/1 Needs to be merged before this one.

cwoolum commented 3 weeks ago

@shairez @thejackshelton , this is ready for review.

shairez commented 3 weeks ago

Great job @cwoolum ! thank you!

Left a few comments