qwikifiers / qwik-ui

Qwik's official Headless and styled component library

https://qwikui.com

MIT License

570 stars 116 forks source link

New-accordion #745

Closed thejackshelton closed 1 week ago

thejackshelton commented 2 weeks ago

What is it?

Refactored Accordion

[ ] Feature / enhancement
[ ] Bug
[ ] Docs / tests
[ ] Other

Why is it needed?

Checklist:

[ ] My code follows the developer guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have ran pnpm change and documented my changes
[ ] I have add necessary docs (if needed)
[ ] Added new tests to cover the fix / functionality

changeset-bot[bot] commented 2 weeks ago

⚠️ No Changeset found

Latest commit: 07ad8b1dbe25fb692bf9ef96c1a49b6ed7c9ca8a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 1 package

| Name | Type | | ----------------- | ----- | | @qwik-ui/headless | Minor |

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

maiieul commented 1 week ago

Ups I approved, but we need to remember to not deprecate the Accordion animated prop.. If you could do that before merging 👍

thejackshelton commented 1 week ago

Ups I approved, but we need to remember to not deprecate the Accordion animated prop.. If you could do that before merging 👍

Yep let me do that

pkg-pr-new[bot] commented 1 week ago

Last Commit Build: 07ad8b1

@qwik-ui/headless(07ad8b1):

npm i https://pkg.pr.new/qwikifiers/qwik-ui/@qwik-ui/headless@07ad8b1

Pull Request Build: #745

@qwik-ui/headless(#745):

npm i https://pkg.pr.new/qwikifiers/qwik-ui/@qwik-ui/headless@745