qwikifiers / qwik-ui

Qwik's official Headless and styled component library
https://qwikui.com
MIT License
604 stars 135 forks source link

[🐞]TOC: you can outscrolll the TOC #842

Open TheMcnafaha opened 3 months ago

TheMcnafaha commented 3 months ago

Which package is affected?

Headless Kit

Describe the bug

You can outpace the TOC

Reproduction

https://github.com/TheMcnafaha/qwik-ui/tree/toc-bug

Steps to reproduce

  1. run code below: pnpm install; pnpm dev
  2. Go to the headless select
  3. Scroll all the way down the page
  4. look at TOC (won't follow you)

System Info

System:
    OS: Linux 6.5 Ubuntu 22.04.4 LTS 22.04.4 LTS (Jammy Jellyfish)
    CPU: (4) x64 Intel(R) Core(TM) i5-7200U CPU @ 2.50GHz
    Memory: 944.52 MB / 7.51 GB
    Container: Yes
    Shell: 5.1.16 - /bin/bash
  Binaries:
    Node: 20.10.0 - ~/.nvm/versions/node/v20.10.0/bin/node
    Yarn: 1.22.21 - ~/.local/share/pnpm/yarn
    npm: 10.2.3 - ~/.nvm/versions/node/v20.10.0/bin/npm
    pnpm: 8.11.0 - ~/.nvm/versions/node/v20.10.0/bin/pnpm
  Browsers:
    Chrome: 125.0.6422.141

Additional Information

There's a chance that this is intended behavior. I do want to make a qwik scroll area in the future to have a full qwik site, so this bug may not be the most important thing ever but I think it shows we need to have tests for all components even if they are private.

TheMcnafaha commented 2 weeks ago

I think we should remove this as a bug. This behavior is present in all TOC that I have seen that don't implement some big footer at the end.