search

qwikifiers / qwik-ui

Qwik's Headless and styled component library
https://qwikui.com
MIT License
636 stars 144 forks source link

[🐞] Select/Combobox Popover Cannot Scroll While Using Trackpad #979

Open Toeler opened 1 month ago

Toeler commented 1 month ago

Which package is affected?

Headless Kit

Describe the bug

When scrolling within a Select or Combobox popover, it attempts to keep the highlighted item in view, preventing you from scrolling down the list

Reproduction

https://stackblitz.com/edit/github-9qoecq-vdjdps?file=src%2Fglobal.css

Steps to reproduce

  1. Click on the trigger to open the scrollable popover list
  2. Place the mouse over one of the items in the list to highlight it
  3. Attempt to scroll down the list (using trackpad scroll on a laptop)

System Info

System:
    OS: macOS 13.0.1
    CPU: (10) arm64 Apple M1 Pro
    Memory: 120.06 MB / 32.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 20.14.0 - ~/.nvm/versions/node/v20.14.0/bin/node
    npm: 10.7.0 - ~/.nvm/versions/node/v20.14.0/bin/npm
    pnpm: 9.4.0 - ~/.nvm/versions/node/v20.14.0/bin/pnpm
    Watchman: 2023.03.13.00 - /opt/homebrew/bin/watchman
  Browsers:
    Chrome: 129.0.6668.72
    Safari: 16.1
  npmPackages:
    @builder.io/qwik: 1.9.0 => 1.9.0 
    @builder.io/qwik-city: 1.9.0 => 1.9.0 
    @qwik-ui/headless: 0.6.1 => 0.6.1 
    typescript: ^5.6.2 => 5.6.2 
    undici: ^6.19.8 => 6.19.8 
    vite: ^5.4.8 => 5.4.8

Additional Information

https://github.com/qwikifiers/qwik-ui/blob/7e87d33c8abcfb6090907ceb80e969b6e28ec559/packages/kit-headless/src/components/select/select-item.tsx#L77 I think that this should only be triggering with the keyboard up/down navigation, and not as frequently as it is currently.

Video Repro: https://github.com/user-attachments/assets/7cef2a70-b1a2-4abc-9fcf-3e686606c736