Open mosajjal opened 5 years ago
couple of points:
1) It's json
instead of yaml
(#45) because I didn't want to introduce a new dependency
2) I have no idea how to implement relays (with __ syntax) in this json :)
Cool template design! My suggestion is relays can be implemented by adding a key "relay" in "servers". It can be nested with several layers. for example:
"servers": [
{
"enabled": true,
"name": "SERVER1",
........
"relay": {
"enabled": true,
"name": "SERVER2",
........
"relay": {
"enabled": true,
"name": "FINAL_SERVE",
........
}
}
}
]
ok I think I got your point. But here's a bigger question. Do we need to identify one of the methods (config file or command line arguments) as a main template and convert the other one to the template? This way we can make pluggable configuration formats connected to pproxy
if we wanted.
Currently I don't see great benefits of using a configuration file. Maybe converting from json config file to command line argument parameter is a good way to make it easier.
I agree with this not being a high priority. Let's keep this here as an open improvement issue but with lower priority. Meanwhile, I'll try to work on some low hanging fruit.
Form my side i dont like that auth informations are handled via command option. I'm under linux and when im doing ps
i see my proxy password what i dont want to!
So in general a +1 from me for the config file! Maybe start with a MVP just for the pw ;)
It would be nice if passwords are not stored in plaintext somewhere. Instead it would be nice if passwords are fetched from linux keyring. e.g. via secret-tool but i guess that is to os specific.
Form my side i dont like that auth informations are handled via command option. I'm under linux and when im doing
ps
i see my proxy password what i dont want to!So in general a +1 from me for the config file! Maybe start with a MVP just for the pw ;)
It would be nice if passwords are not stored in plaintext somewhere. Instead it would be nice if passwords are fetched from linux keyring. e.g. via secret-tool but i guess that is to os specific.
I use python script to avoid auth information leak via command option. Python script is better than config file, I think.
Forget shadowsocks. We config like this:
arg=( '-l','socks5://127.0.0.1:8080', '-r','ss://cipher:key@127.0.0.1:8000', ) pproxy.server.main(args)
Isn't it cool?
Hi, here's a very basic config file template designed to work with
pproxy
. I'm open for all sorts of feedback and improvement as this probably covers ~60 percent of whatpproxy
offers.