qwreey / quick-settings-tweaks

Let's tweak gnome 43's quick settings! You can add Media Controls, Notifications, Volume Mixer on quick settings and remove useless buttons!
https://extensions.gnome.org/extension/5446/quick-settings-tweaker/
GNU General Public License v3.0
346 stars 19 forks source link

Using the wifi quick toggle restores some other hidden toggles #65

Open julienfalque opened 1 year ago

julienfalque commented 1 year ago

How to reproduce

  1. In the extension settings, enable the wifi toggle and disable bluetooth and airplane mode ones
  2. Use the wifi toggle to enable or disable the wifi

What is the expected result

The state of the wifi changes, nothing more

What happens instead

The wifi state changes as expected but the bluetooth and airplane mode toggles reappear, which is unexpected.

jrom99 commented 1 year ago

I have a similar situation. This doesn't happen every time and manually switching the airplane toggle on and off fixes the problem.

  1. Wifi and bluetooth toggles enabled, airplane mode disabled
  2. After using bluetooth quick toggle, the airplane one reappears

As far as I've tested, the airplane toggle sometimes ignores the setting and appears for some time after a fresh restart. However, this doesn't happen every time.

OS version: Fedora 37 (6.0.15-300.fc37.x86_64) GNOME version: GNOME Shell 43.2 on Wayland Extension version: 17

jrom99 commented 1 year ago

I've got this message on journalctl -e, I'll take a look when I have more time, but maybe it can help in the meantime.

JS ERROR: RangeError: Provided GType name 'qwreey.quick-settings-tweaks.prefs.otherPage' is not valid; automatically sanitized to 'qwr>
                             _createGTypeName@resource:///org/gnome/gjs/modules/core/overrides/GObject.js:185:22
                             registerGObjectType@resource:///org/gnome/gjs/modules/core/overrides/GObject.js:532:41
                             registerWidgetType@resource:///org/gnome/gjs/modules/core/overrides/Gtk.js:92:39
                             _init/GObject.Object._classInit@resource:///org/gnome/gjs/modules/core/overrides/GObject.js:515:33
                             _init/Gtk.Widget._classInit@resource:///org/gnome/gjs/modules/core/overrides/Gtk.js:75:31
                             registerClass@resource:///org/gnome/gjs/modules/core/overrides/GObject.js:74:23
                             @/home/junior/.local/share/gnome-shell/extensions/quick-settings-tweaks@qwreey/prefPages/other.js:11:25
                             @/home/junior/.local/share/gnome-shell/extensions/quick-settings-tweaks@qwreey/prefs.js:11:5
                             _init@resource:///org/gnome/Shell/Extensions/js/extensionPrefsDialog.js:23:33
                             ExtensionPrefsDialog@resource:///org/gnome/Shell/Extensions/js/extensionPrefsDialog.js:10:4
                             OpenExtensionPrefsAsync@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:124:33
                             async*_handleMethodCall@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:368:35
                             _wrapJSObject/<@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:401:34
                             run@resource:///org/gnome/Shell/Extensions/js/dbusService.js:186:20
                             main@resource:///org/gnome/Shell/Extensions/js/main.js:22:13
                             run@resource:///org/gnome/gjs/modules/script/package.js:206:19
                             start@resource:///org/gnome/gjs/modules/script/package.js:190:8
                             @/usr/share/gnome-shell/org.gnome.Shell.Extensions:1:17