qxeii / nox-renoxed

Minecraft mob and difficulty overhaul for Fabric.
Other
2 stars 4 forks source link

Crashes and Bugs in "Older" Versions. #32

Open ihymyly opened 1 month ago

ihymyly commented 1 month ago

Version 2.7.2 crashes for 1.20.5 and 1.20.6

All previous versions, disabling projectile resistance doesn't actually disable it. Arrows "vanish" rather than damaging the target like it should. Please update 1.20.1. I understand you may be busy with other projects but this mod has a lot of genuinely amazing features fit for Vanilla-esque gameplay.

Edit: Entities still keep their immunity to arrow damage_type. Unable to locate source. Screenshot 2024-08-18 001918 Screenshot 2024-08-18 001931

qxeii commented 3 weeks ago

I generally don't maintain support for older versions simply because I like always having the newest content (and if i did the workload would increase permanently every time I updated the mod to a new version, as I do not use one of those fancy multi-version libraries). I love this mod as much as you do which is why I took it upon myself to update it, but this is essentially just me making the work I did in order to make a private modpack public.

As you have guessed, I am working on some private non-modding related projects right now and have not actually played modded minecraft in a while. If you would like to make an attempt at backporting/fixing the older versions of this mod I implore you to go ahead! I would say fixing bugs in existing projects is one of the best ways to learn how to code as it's how I started out.

ihymyly commented 3 weeks ago

Yeah, I understand. See, I would, but I possess zero idea where to start (and no coding skills Dx). As I mentioned in the post, I have no idea what the source is. The Mixins seem to work fine, and I've tried cross-referencing the updates, but no luck. Some direction would be appreciated. Screenshot 2024-08-18 003127

qxeii commented 3 weeks ago

Are you able to view the git diffs (should have a lot of red and green lines to show removals and additions) of the update that fixes it? That should show you whatever and wherever the change I (or someone else) made was.

(I would also recommend getting IntelliJ IDEA if you don't have it already because it makes parsing through code much easier)

ihymyly commented 3 weeks ago

Yeah that's exactly what I'm doing. Going through the history and hoping I find something that looks like whatever you said lol.

Note: On 1.21, you fixed the issue with the damage immunity, but only for Slimes (at least, the Patchbox Pull Request did). Evokers and Witches still have the same issue, i.e. completely immune to projectiles, and Piercing phases through.

Edit: Damage immunity among us. Slimes can take fall damage, regardless of whether or not its enabled in the config. Spiders, Silverfish, and Endermites are completely immune to fall damage, even if disabled in the config. Ender Dragon is completely immune to explosions. Witches and Evokers still take damage from "magic" (potions).