Open Annapooraniqxf2 opened 4 years ago
Please review this pull request before 25-Aug-2020.
Annapoorani, I can do this next Monday
On Tue, Aug 18, 2020 at 1:39 PM Annapooraniqxf2 notifications@github.com wrote:
Please review this pull request before 25-Aug-2020.
— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/qxf2/cars-api/pull/9#issuecomment-675328926, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADZCGJNO7DFQIAVR7KEUVULSBIZMTANCNFSM4P6NNWTQ .
-- Avinash Shetty Qxf2 Services http://qxf2.com/ +91 9900234948 | avinash@qxf2.com
Please review this fix and let me know the suggestions. Thanks
Hi Annapoorani, I tested by running it multiple times, the headers and status were varying. What should the change_json_value update? I was expecting it to clear the actual response and return a Null value, which wasn't happening.
Also, I noted a small typo in spoiler.py comments. function is misspelled as funtion. "Use this decorator to vary your funtion return value"
@Annapooraniqxf2 I reviewed the code today. This is what I did/see
Code Review Session
Issues/Queries
We wanted to show the different api responses to our trainee. So we have added the decorator which returns different responses for a same request. We are randomly generating different responses for each request. We are trying to change the headers, values and status code.
Added file: utils/spoiler.py
Changed files: cars_app.py We have added the decorator as of now for the /cars route method only.
How do we test it: