qxmpp-project / qxmpp

Cross-platform C++ XMPP client and server library
412 stars 196 forks source link

Move build constants into separate file #412

Closed melvo closed 2 years ago

melvo commented 2 years ago

Before opening a pull-request please do:

codecov[bot] commented 2 years ago

Codecov Report

Merging #412 (159b070) into master (93f9c8c) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 159b070 differs from pull request most recent head 33af3b9. Consider uploading reports for the commit 33af3b9 to get more accurate results

@@           Coverage Diff           @@
##           master     #412   +/-   ##
=======================================
  Coverage   75.96%   75.96%           
=======================================
  Files         235      235           
  Lines       20384    20384           
=======================================
  Hits        15485    15485           
  Misses       4899     4899           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 93f9c8c...33af3b9. Read the comment docs.

lnjX commented 2 years ago

You can't change the contents that QXmppGlobal.h includes. The stuff from the new BuildConstants is missing.

I'd also suggest to only put the possible minimum into BuildConstants, so only the lines where @...@ is used.

lnjX commented 2 years ago

Sorry, the "closed" was a mistake (I merged it to master before pushing it here).