qxmpp-project / qxmpp

Cross-platform C++ XMPP client and server library
410 stars 197 forks source link

Implement XEP-0293: Jingle RTP Feedback Negotiation stanza parts #455

Closed melvo closed 1 year ago

melvo commented 2 years ago

PR check list:

codecov[bot] commented 2 years ago

Codecov Report

Base: 68.61% // Head: 68.92% // Increases project coverage by +0.31% :tada:

Coverage data is based on head (3d066f9) compared to base (8296945). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #455 +/- ## ========================================== + Coverage 68.61% 68.92% +0.31% ========================================== Files 283 283 Lines 24572 24821 +249 ========================================== + Hits 16859 17108 +249 Misses 7713 7713 ``` | [Impacted Files](https://codecov.io/gh/qxmpp-project/qxmpp/pull/455?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qxmpp-project) | Coverage Δ | | |---|---|---| | [src/base/QXmppJingleIq.cpp](https://codecov.io/gh/qxmpp-project/qxmpp/pull/455/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qxmpp-project#diff-c3JjL2Jhc2UvUVhtcHBKaW5nbGVJcS5jcHA=) | `88.92% <100.00%> (+2.13%)` | :arrow_up: | | [src/base/QXmppJingleIq.h](https://codecov.io/gh/qxmpp-project/qxmpp/pull/455/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qxmpp-project#diff-c3JjL2Jhc2UvUVhtcHBKaW5nbGVJcS5o) | `100.00% <100.00%> (ø)` | | | [tests/qxmppjingleiq/tst\_qxmppjingleiq.cpp](https://codecov.io/gh/qxmpp-project/qxmpp/pull/455/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qxmpp-project#diff-dGVzdHMvcXhtcHBqaW5nbGVpcS90c3RfcXhtcHBqaW5nbGVpcS5jcHA=) | `100.00% <100.00%> (ø)` | | | [tests/qxmppomemodata/tst\_qxmppomemodata.cpp](https://codecov.io/gh/qxmpp-project/qxmpp/pull/455/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qxmpp-project#diff-dGVzdHMvcXhtcHBvbWVtb2RhdGEvdHN0X3F4bXBwb21lbW9kYXRhLmNwcA==) | `98.25% <0.00%> (+<0.01%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qxmpp-project). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qxmpp-project)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.