FileSharingManager: Apply 'clang-format'

[melvo]

PR check list:

• [x] Document your code
• [x] Add \since QXmpp 1.X, QXMPP_EXPORT
• [x] Fix doxygen warnings (see log when building with -DBUILD_DOCUMENTATION=ON)
• [x] Update doc/doap.xml
• [x] Add unit tests
• [x] Format the code: Run clang-format -i src/<edited-file(s)> tests/<edited-file(s)>

[jbruechert]

I don't get any changes when running clang-format-15 -i src/client/QXmppFileSharingManager.cpp on master. Which version of clang-format are you using?

[codecov[bot]]

Codecov Report

Base: 68.51% // Head: 68.51% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (8002cf6) compared to base (0cd975e). Patch has no changes to coverable lines.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #486 +/- ## ======================================= Coverage 68.51% 68.51% ======================================= Files 294 294 Lines 25340 25341 +1 ======================================= + Hits 17361 17362 +1 Misses 7979 7979 ``` | [Impacted Files](https://codecov.io/gh/qxmpp-project/qxmpp/pull/486?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qxmpp-project) | Coverage Δ | | |---|---|---| | [src/client/QXmppFileSharingManager.cpp](https://codecov.io/gh/qxmpp-project/qxmpp/pull/486/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qxmpp-project#diff-c3JjL2NsaWVudC9RWG1wcEZpbGVTaGFyaW5nTWFuYWdlci5jcHA=) | `0.00% <ø> (ø)` | | | [tests/qxmppomemodata/tst\_qxmppomemodata.cpp](https://codecov.io/gh/qxmpp-project/qxmpp/pull/486/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qxmpp-project#diff-dGVzdHMvcXhtcHBvbWVtb2RhdGEvdHN0X3F4bXBwb21lbW9kYXRhLmNwcA==) | `98.25% <0.00%> (+<0.01%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qxmpp-project). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=qxmpp-project)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

[melvo]

I don't get any changes when running clang-format-15 -i src/client/QXmppFileSharingManager.cpp on master. Which version of clang-format are you using?

I used clang-format-14.

[lnjX]

This looks wrong. And in general, you only have to format your personal changes, not the whole project. I can format the whole project when releasing or once a year, so we don't get too much noise from me forgetting to run clang format. A CI check for PRs could also be helpful.

[melvo]

A CI check for PRs could also be helpful.

I opened #491 for that purpose.

[melvo]

@lnjX This should be reopened since both https://github.com/qxmpp-project/qxmpp/pull/491/files#diff-e8fbcf424898cae6fc11412c52bbd57a6bd05561b745e4e07134155327fd402d and my now updated local clang-format-15 reformat it that way.

[lnjX]

I cannot reopen this (the branch was recreated)

[melvo]

It is fixed by 98bfe936e25c462df8e3650a436d9db31b237cd9.