Closed melvo closed 1 year ago
@lnjX I think that reactions
would fit better than reaction
because it is a list of emojis. What do you think?
5.9 and windows builds are broken
@lnjX I think that
reactions
would fit better thanreaction
because it is a list of emojis. What do you think?
yes, reactions
would be better, it makes more sense + the XML element is also called reactions.
I think it's unfortunate that the XEP doesn't use message attaching (yes, I've read the note about it in the XEP), because you can't easily fetch all the reactions via MAM but you need to receive all later MAM reaction messages to display reactions correctly.
Edit: I actually meant Message Fastening (https://xmpp.org/extensions/xep-0422.html)
I think it's unfortunate that the XEP doesn't use message attaching (yes, I've read the note about it in the XEP), because you can't easily fetch all the reactions via MAM but you need to receive all later MAM reaction messages to display reactions correctly.
Edit: I actually meant Message Fastening (https://xmpp.org/extensions/xep-0422.html)
@mar-v-in What do you think about that?
Base: 68.50% // Head: 68.60% // Increases project coverage by +0.09%
:tada:
Coverage data is based on head (
b3e8ea0
) compared to base (19c9d12
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
As of now, Fastening (XEP-0422) does not solve any issues here. MAM-FC (XEP-0427) - even if implemented by a server - would not be suitable for reactions as it doesn't preserve the information of the sender of the fastening in collate mode (simplified mode would only remove the reactions from MAM, full mode is what we have now). Sensible summarizing/collating of reactions would only be possible with server directly supporting reactions (and its processing rules), which means using fastening would not help realizing that.
@mar-v-in I see it's not ideal. I think what would still make sense is to fetch old messages in collate
mode and to load all fastenings/all reaction messages with a fastenings
query.
Currently I see a problem in the following scenario:
There're (at least) two ways to workaround this a) to load all messages in chronological order or b) to store the reactions messages even if the message id is unknown when receiving the reaction.
I haven't thought about fastenings in detail, maybe message fastenings (or mam fc) still need some adjustments or changes in the architecture, but in general it sounds like the "right way" to do this.
@mar-v-in I see your point. My main goal would be to be able to receive all attached/related messages at once. Your draft sounds interesting and having it work both ways (also for replys) sounds very useful.
PR check list:
\since QXmpp 1.X
,QXMPP_EXPORT
-DBUILD_DOCUMENTATION=ON
)doc/doap.xml
clang-format -i src/<edited-file(s)> tests/<edited-file(s)>