qxmpp-project / qxmpp

Cross-platform C++ XMPP client and server library
408 stars 197 forks source link

Disallow usage of qt keywords in QXmpp #503

Closed lnjX closed 1 year ago

lnjX commented 1 year ago
  1. qt keywords conflict with some parts of the standard library, e.g. you'll get compile errors if anything has a function called emit
  2. We can't use qt keywords in headers to allow projects without qt keywords to use QXmpp. This is the current policy. However, we haven't disabled the keywords in QXmpp ("using them in .cpp files is still fine") and so in some places signals have been used unnoticed again.