Add MIX support - Githubissues

qxmpp-project / qxmpp

Cross-platform C++ XMPP client and server library

401 stars 197 forks source link

Add MIX support #589

Closed melvo closed 3 months ago

melvo commented 8 months ago

Funded by NLnet via NGI Assure.

PR check list:

[x] Document your code
[x] Add \since QXmpp 1.X, QXMPP_EXPORT
[x] Fix doxygen warnings (see log when building with -DBUILD_DOCUMENTATION=ON)
[x] Update doc/doap.xml
[x] Add unit tests
[x] Format the code: Run clang-format -i src/<edited-file(s)> tests/<edited-file(s)>

lnjX commented 3 months ago

clazy warnings:

src/base/QXmppMixItems.cpp:136:17: warning: unused QStringList [-Wclazy-unused-non-trivial-variable]
                const auto administratorJidList = value.toStringList();
                ^

src/client/QXmppMixManager.cpp:1305:23: warning: Mixing iterators with const_iterators [-Wclazy-strict-iterators]
    d->services.erase(itr);
                      ^