search

qychen1982 / crashpad

Automatically exported from code.google.com/p/crashpad
0 stars 0 forks source link

Chromium integration #12

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Although Crashpad was always intended to build as part of Chromium, a few small 
changes are needed on the Crashpad side to fully enable this. This bug tracks 
that work.

https://codereview.chromium.org/986033002/: Allow Crashpad to build in the 
Chromium tree
https://codereview.chromium.org/986873002/: Set the chromium_code GYP variable
https://codereview.chromium.org/990553003/: Set product_name on many targets to 
use a crashpad_ prefix
https://codereview.chromium.org/989023002/: util/mach/exc_server_variants.cc: 
Remove unused typedefs

Original issue reported on code.google.com by mark@chromium.org on 7 Mar 2015 at 7:20

GoogleCodeExporter commented 9 years ago 
https://codereview.chromium.org/996433002: run_tests.py: find test executables 
in an in-Chromium build

Original comment by mark@chromium.org on 9 Mar 2015 at 7:39

GoogleCodeExporter commented 9 years ago 
https://codereview.chromium.org/992693003/: Add ASSERT_DEATH_CHECK() to do 
ASSERT_DEATH() of CHECK() failures

Original comment by mark@chromium.org on 9 Mar 2015 at 9:03

GoogleCodeExporter commented 9 years ago 
The work needed to get Crashpad building in the Chromium tree is done on the 
Crashpad side in these changes:

b665a0db075e: Allow Crashpad to build in the Chromium tree
b770a51f2bdf: Set the chromium_code GYP variable
b256df05344d: Set target_name on many targets to use a crashpad_ prefix
55861e88ce78: util/mach/exc_server_variants.cc: Remove unused typedefs
e1df1599e157: run_tests.py: find test executables in an in-Chromium build
26804a0be1f2: Add ASSERT_DEATH_CHECK() to do ASSERT_DEATH() of CHECK() failures
c4a8b32495b5: Fix ExceptionPorts.TaskAndThreadExceptionPorts under better 
compiler optimization

Other changes needed for Chromium integration have landed:

1a635e3a799c: Define the Settings interface for a CrashReportDatabase and 
provide a Mac implementation
4ef649d1896a: CrashReportDatabse: set the last upload attempt time from 
RecordUploadAttempt()
42db629ee334: handler/mac: Respect the uploads-enabled user preference and 
rate-limit upload attempts to no more than 1 per hour
b8d2129bc1c0: handler/mac: Forward exceptions to the system crash reporter

One more change needed for Chromium integration is pending:

https://codereview.chromium.org/997713002/: Allow exception forwarding to the 
system’s native crash reporter to be disabled

Original comment by mark@chromium.org on 10 Mar 2015 at 10:48

GoogleCodeExporter commented 9 years ago 
fd14ae64508c: crashpad_client: expose the crashpad root as an include_dir to 
dependents

Original comment by mark@chromium.org on 12 Mar 2015 at 9:22

GoogleCodeExporter commented 9 years ago 
7edad7c412da: client/simulate_crash_mac.h: Qualify NativeCPUContext with the 
crashpad namespace

Original comment by mark@chromium.org on 12 Mar 2015 at 9:57

GoogleCodeExporter commented 9 years ago 
94471409a183: handler/mac: Increase the upload timeout from the default 15s to 
60s

Original comment by mark@chromium.org on 13 Mar 2015 at 4:49

GoogleCodeExporter commented 9 years ago 
Chrome-side integration is https://codereview.chromium.org/1001103002/.

Original comment by mark@chromium.org on 13 Mar 2015 at 4:50

GoogleCodeExporter commented 9 years ago 
Crashpad landed in Chrome at 
https://chromium.googlesource.com/chromium/src/+/d413b2dcb54d523811d386f1ff4084f
677a6d089 with a follow-up fix for signing at 
https://chromium.googlesource.com/chromium/src/+/18fcae1dee1acbddfa380415837a5b7
8480ae558. Both of these are present in Chrome canary 43.0.2331.3.

See the integration announcements at 
https://groups.google.com/a/chromium.org/d/topic/crashpad-dev/nsagBXAnoIM and 
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/6eouc7q2j_g.

Ongoing fixes are tracked at 
https://code.google.com/p/chromium/issues/detail?id=466964.

Original comment by mark@chromium.org on 13 Mar 2015 at 9:59