search

qychen1982 / crashpad

Automatically exported from code.google.com/p/crashpad
0 stars 0 forks source link

HTTPTransportWin does not respect the caller-supplied timeout #8

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Callers can call HTTPTransport::SetTimeout() to specify their own desired 
timeout. HTTPTransportWin does not respect this. It appears to use the OS 
defaults. It could base a call to WinHttpSetTimeouts() on the caller-supplied 
timeout value. HTTPTransportMac sets NSMutableURLRequest’s timeoutInterval 
property.

WinHTTP does have default values for most of its timeout types, but its 
documentation claims an infinite timeout for dwResolveTimeout. (Practically, I 
bet the resolver will time out and WinHTTP will return an error.)

Original issue reported on code.google.com by mark@chromium.org on 5 Feb 2015 at 9:35

GoogleCodeExporter commented 9 years ago

Original comment by scottmg@chromium.org on 6 Feb 2015 at 12:05

GoogleCodeExporter commented 9 years ago 
This was fixed in 
https://chromium.googlesource.com/crashpad/crashpad/+/b16b89c89dc2292e66d025148d
1b4cd4a94a526b, right?

Original comment by mark@chromium.org on 9 Mar 2015 at 6:15

GoogleCodeExporter commented 9 years ago 
Right.

Original comment by scottmg@chromium.org on 9 Mar 2015 at 7:46