search

qysim / DEVoca

DEVoca: 개발자를 위한 단어장
https://defiant-piccolo-ad9.notion.site/DEVoca-43b00aab7a2545bdbead9917bf7e96ba
0 stars 0 forks source link

[BE] feat : 단어 목록 조회 기능 추가(#10) - [merged] #259

Closed qysim closed 6 months ago

qysim commented 7 months ago

In GitLab by @juyi077 on Jan 29, 2024, 23:46

_Merges BE/Feat/10_wordList -> develop

이슈

작업 사항

qysim commented 7 months ago

In GitLab by @juyi077 on Jan 29, 2024, 23:46

requested review from @amysia

qysim commented 7 months ago

In GitLab by @juyi077 on Jan 29, 2024, 23:47

requested review from @cheesecat47 and removed review request for @amysia

qysim commented 7 months ago

In GitLab by @juyi077 on Jan 29, 2024, 23:47

requested review from @jiyun3016 and removed review request for @cheesecat47

qysim commented 7 months ago

In GitLab by @amysia on Jan 30, 2024, 24:03

approved this merge request

qysim commented 7 months ago

In GitLab by @cheesecat47 on Jan 30, 2024, 24:21

Commented on a304fb3f664078f77ae62a3b9cea242c59125576

P5: 이 커밋은 이 MR의 범위는 아닌 것 같습니다. 다음에 MR 올릴 때는 분리해서 올려주면 좋을 것 같습니다.

qysim commented 7 months ago

In GitLab by @cheesecat47 on Jan 30, 2024, 24:21

Commented on DEVoca-api/src/main/java/com/ssafy/devoca/word/controller/WordController.java line 35

P3: 매핑을 명시하면 좋을 것 같습니다.

    @GetMapping("")
qysim commented 7 months ago

In GitLab by @cheesecat47 on Jan 30, 2024, 24:21

Commented on DEVoca-api/src/main/java/com/ssafy/devoca/word/controller/WordController.java line 36

P2: L#40을 보니 List 타입을 반환하는 것 같은데, <?>보다는 타입을 명시해주는 것이 좋을 것 같습니다.

qysim commented 7 months ago

In GitLab by @cheesecat47 on Jan 30, 2024, 24:21

Commented on DEVoca-api/src/main/java/com/ssafy/devoca/word/model/WordDTO.java line 11

P5: @Schema 태그로 각 파라미터 설명 추가해두면 Swagger 페이지에서 볼 수 있습니다.

qysim commented 7 months ago

In GitLab by @cheesecat47 on Jan 30, 2024, 24:21

Commented on DEVoca-api/src/main/java/com/ssafy/devoca/word/service/WordServiceImpl.java line 31

P1: 이렇게 하면 단어가 300개라면 단어 사전에 진입할 때마다 300번의 쿼리가 발생할 것 같은데, MyBatis 쿼리에서 Join과 Collections를 사용하지 않고 두 개의 쿼리로 분리한 이유가 있을까요?

qysim commented 7 months ago

In GitLab by @cheesecat47 on Jan 30, 2024, 24:21

Commented on DEVoca-api/src/main/resources/mapper/word/word.xml line 25

P2: 조건으로 제한을 걸어야 할 것 같습니다. 만약 DB에 저장된 단어가 10만 개면 매 번 10만 개 길이의 리스트를 반환할 것 같습니다.

qysim commented 7 months ago

In GitLab by @cheesecat47 on Jan 30, 2024, 24:21

수정 커밋 요청합니다.

qysim commented 7 months ago

In GitLab by @juyi077 on Jan 30, 2024, 10:31

Commented on DEVoca-api/src/main/java/com/ssafy/devoca/word/controller/WordController.java line 36

에러 발생 시 String을 반환해서 에러 핸들링 메소드를 Object로 변경하고 getWordList 메소드도 Object로 명시하겠습니다.

qysim commented 7 months ago

In GitLab by @juyi077 on Jan 30, 2024, 10:32

Commented on DEVoca-api/src/main/java/com/ssafy/devoca/word/model/WordDTO.java line 11

Swagger 페이지 준비되면 수정해서 다시 커밋하겠습니다.

qysim commented 7 months ago

In GitLab by @amysia on Jan 30, 2024, 10:42

unapproved this merge request

qysim commented 7 months ago

In GitLab by @juyi077 on Jan 30, 2024, 14:52

Commented on a304fb3f664078f77ae62a3b9cea242c59125576

넵 그렇게 하겠습니다.

qysim commented 7 months ago

In GitLab by @juyi077 on Jan 30, 2024, 14:53

Commented on DEVoca-api/src/main/java/com/ssafy/devoca/word/controller/WordController.java line 35

넵 명시하겠습니다.

qysim commented 7 months ago

In GitLab by @juyi077 on Jan 30, 2024, 15:03

Commented on DEVoca-api/src/main/java/com/ssafy/devoca/word/service/WordServiceImpl.java line 31

join과 collection을 사용하여 수정했습니다.

qysim commented 7 months ago

In GitLab by @juyi077 on Jan 30, 2024, 15:05

Commented on DEVoca-api/src/main/resources/mapper/word/word.xml line 25

인덱스를 사용하여 알파벳별로 단어를 조회하기로 변경했습니다. 이후에 기능 추가하겠습니다.

qysim commented 7 months ago

In GitLab by @juyi077 on Jan 30, 2024, 15:11

Commented on a304fb3f664078f77ae62a3b9cea242c59125576

changed this file in version 2 of the diff

qysim commented 7 months ago

In GitLab by @juyi077 on Jan 30, 2024, 15:11

Commented on DEVoca-api/src/main/java/com/ssafy/devoca/word/controller/WordController.java line 35

changed this line in version 2 of the diff

qysim commented 7 months ago

In GitLab by @juyi077 on Jan 30, 2024, 15:11

Commented on DEVoca-api/src/main/java/com/ssafy/devoca/word/controller/WordController.java line 36

changed this line in version 2 of the diff

qysim commented 7 months ago

In GitLab by @juyi077 on Jan 30, 2024, 15:11

Commented on DEVoca-api/src/main/java/com/ssafy/devoca/word/service/WordServiceImpl.java line 31

changed this line in version 2 of the diff

qysim commented 7 months ago

In GitLab by @juyi077 on Jan 30, 2024, 15:11

added 19 commits

Compare with previous version

qysim commented 7 months ago

In GitLab by @juyi077 on Jan 30, 2024, 15:17

requested review from @amysia and removed review request for @jiyun3016

qysim commented 7 months ago

In GitLab by @juyi077 on Jan 30, 2024, 16:44

added 1 commit

Compare with previous version

qysim commented 7 months ago

In GitLab by @juyi077 on Jan 30, 2024, 16:46

Commented on DEVoca-api/src/main/java/com/ssafy/devoca/word/controller/WordController.java line 36

List를 명시하고 에러는 Collections.emptyList()를 반환하는 것으로 수정했습니다.

qysim commented 7 months ago

In GitLab by @cheesecat47 on Jan 30, 2024, 16:52

resolved all threads

qysim commented 7 months ago

In GitLab by @cheesecat47 on Jan 30, 2024, 16:53

approved this merge request

qysim commented 7 months ago

In GitLab by @cheesecat47 on Jan 30, 2024, 16:53

수고많았습니다.

qysim commented 7 months ago

In GitLab by @amysia on Jan 30, 2024, 17:19

approved this merge request

qysim commented 7 months ago

In GitLab by @cheesecat47 on Jan 30, 2024, 17:21

mentioned in commit a74b552c814a5c765334eea31cb6647b30b98ba9