search

qysim / DEVoca

DEVoca: 개발자를 위한 단어장
https://defiant-piccolo-ad9.notion.site/DEVoca-43b00aab7a2545bdbead9917bf7e96ba
0 stars 0 forks source link

[BE] feat: 카카오 소셜 로그인 (#17) - [merged] #267

Closed qysim closed 4 months ago

qysim commented 5 months ago

In GitLab by @jiyun3016 on Jan 30, 2024, 14:51

_Merges BE/Feat/17_kakaologin -> develop

로그인 및 토큰 발급 완료

qysim commented 5 months ago

In GitLab by @jiyun3016 on Jan 30, 2024, 15:27

added 29 commits

Compare with previous version

qysim commented 5 months ago

In GitLab by @cheesecat47 on Jan 30, 2024, 15:32

Commented on DEVoca-api/src/main/java/com/ssafy/devoca/user/controller/KakaoController.java line 19

P4: API 명세서에는 없는 엔드포인트인 것 같은데, 추가된 내용일까요?

qysim commented 5 months ago

In GitLab by @cheesecat47 on Jan 30, 2024, 15:32

Commented on DEVoca-api/src/main/java/com/ssafy/devoca/user/controller/KakaoController.java line 19

P3: 코드와 주석이 큰 관계는 없어 보이는데, javadoc 등으로 한 데 모아줄 수 있을까요?

qysim commented 5 months ago

In GitLab by @cheesecat47 on Jan 30, 2024, 15:32

Commented on DEVoca-api/src/main/java/com/ssafy/devoca/user/controller/KakaoController.java line 26

P4: !6 에서는 ResponseEntity.status(HttpStatus.OK).body(...)와 같이 사용했던데, 둘 중 한 가지 방법으로 통일하는 것이 좋아보입니다.

qysim commented 5 months ago

In GitLab by @cheesecat47 on Jan 30, 2024, 15:32

Commented on DEVoca-api/src/main/java/com/ssafy/devoca/user/controller/OauthController.java line 13

P4: API 명세서에는 없는 엔드포인트인 것 같은데, 추가된 내용일까요?

qysim commented 5 months ago

In GitLab by @cheesecat47 on Jan 30, 2024, 15:32

Commented on DEVoca-api/src/main/java/com/ssafy/devoca/user/model/KakaoDTO.java line 6

P5: Builder 패턴을 사용한 이유가 있을까요?

qysim commented 5 months ago

In GitLab by @cheesecat47 on Jan 30, 2024, 15:32

Commented on DEVoca-api/src/main/java/com/ssafy/devoca/user/service/KakaoService.java line 30

P5: 이 주석은 어떤 의미인가요?

qysim commented 5 months ago

In GitLab by @cheesecat47 on Jan 30, 2024, 15:32

Commented on DEVoca-api/src/main/java/com/ssafy/devoca/user/service/KakaoService.java line 45

P2: stdout 사용은 지양 부탁합니다. log.debug가 좋을 듯 합니다.

qysim commented 5 months ago

In GitLab by @jiyun3016 on Jan 30, 2024, 16:02

Commented on DEVoca-api/src/main/java/com/ssafy/devoca/user/controller/KakaoController.java line 19

추가하겠습니다.

qysim commented 5 months ago

In GitLab by @jiyun3016 on Jan 30, 2024, 16:04

Commented on DEVoca-api/src/main/java/com/ssafy/devoca/user/controller/KakaoController.java line 19

코드 이해에 필요한 주석이라고 생각해서 적어두었지만 의견 참고하여 삭제하겠습니다.

qysim commented 5 months ago

In GitLab by @jiyun3016 on Jan 30, 2024, 16:06

Commented on DEVoca-api/src/main/java/com/ssafy/devoca/user/service/KakaoService.java line 30

변수로 선언된 URI가 밑에서 주석에 쓰여진 URI 생성하는 곳에 사용됩니다. 참고하기 위해 적어두었습니다.

qysim commented 5 months ago

In GitLab by @amysia on Jan 30, 2024, 17:30

approved this merge request

qysim commented 5 months ago

In GitLab by @amysia on Jan 30, 2024, 17:30

unapproved this merge request

qysim commented 5 months ago

In GitLab by @jiyun3016 on Jan 30, 2024, 17:55

Commented on DEVoca-api/src/main/java/com/ssafy/devoca/user/controller/KakaoController.java line 19

changed this line in version 3 of the diff

qysim commented 5 months ago

In GitLab by @jiyun3016 on Jan 30, 2024, 17:55

Commented on DEVoca-api/src/main/java/com/ssafy/devoca/user/controller/KakaoController.java line 26

changed this line in version 3 of the diff

qysim commented 5 months ago

In GitLab by @jiyun3016 on Jan 30, 2024, 17:55

Commented on DEVoca-api/src/main/java/com/ssafy/devoca/user/controller/OauthController.java line 13

changed this line in version 3 of the diff

qysim commented 5 months ago

In GitLab by @jiyun3016 on Jan 30, 2024, 17:55

Commented on DEVoca-api/src/main/java/com/ssafy/devoca/user/service/KakaoService.java line 45

changed this line in version 3 of the diff

qysim commented 5 months ago

In GitLab by @jiyun3016 on Jan 30, 2024, 17:55

added 11 commits

Compare with previous version

qysim commented 5 months ago

In GitLab by @amysia on Jan 30, 2024, 18:02

Commented on DEVoca-api/src/main/java/com/ssafy/devoca/user/controller/KakaoController.java line 20

P3: Error의 경우 처리 방식을 #10 등과 통일하는 게 좋지 않을까요??

qysim commented 5 months ago

In GitLab by @amysia on Jan 30, 2024, 18:05

approved this merge request

qysim commented 5 months ago

In GitLab by @jiyun3016 on Jan 30, 2024, 22:03

Commented on DEVoca-api/src/main/java/com/ssafy/devoca/user/controller/KakaoController.java line 20

앞으로 반영하도록 하겠습니다. :grinning:

qysim commented 5 months ago

In GitLab by @cheesecat47 on Jan 30, 2024, 23:16

approved this merge request

qysim commented 5 months ago

In GitLab by @cheesecat47 on Jan 31, 2024, 09:27

resolved all threads

qysim commented 5 months ago

In GitLab by @cheesecat47 on Jan 31, 2024, 09:27

mentioned in commit 4bbe56bc9054b5dcc709ebcb588b7f882bccc18c