search

qzhu2017 / PyXtal_ml

a Python3 library for ML modeling materials properties
MIT License
11 stars 1 forks source link

What is the use of this line? #38

Closed yanxon closed 5 years ago

yanxon commented 5 years ago

https://github.com/qzhu2017/PyXtal_ml/blob/733ecdfdb97149b9de469ae8f62c0020c0b8196c/pyxtal_ml/ml/dl_pytorch.py#L141

I think this is a typo, isn't it?

qzhu2017 commented 5 years ago

I copied it from the pytorch doc.

yanxon commented 5 years ago

I don't think it's necessary because its equivalent to ReLU function. Deleting this line actually improve the result.