search

qzhu2017 / XRD

X-ray diffraction calculations
MIT License
7 stars 6 forks source link

VXRD: Enhancements #21

Open sabaronett opened 4 years ago

sabaronett commented 4 years ago
sabaronett commented 4 years ago

@qzhu2017, for JSmol, do we want to include the unzipped static/jsmol in this repo or just jsmol.zip and instruct the end-user to unpack it themselves? Unpacking it makes it easier for anyone cloning the repo, but it will also commit almost 2,000 individual files and add another ~80 MBs.

Let me know what you prefer.

image

qzhu2017 commented 4 years ago

@sabaronett Let's just keep this file local and do not upload it to github repo

sabaronett commented 4 years ago

@qzhu2017 JSmol has been added in 9994626d4b41c8f4480f7b0de3f0dbda131a3af3. Per c01e932873e950281bccf42e26914bac3b956171, you'll need to unzip jsmol.zip in the right subfolder (where jsmol.js is).

After checking it out, what's your thoughts on the following open questions?

qzhu2017 commented 4 years ago

@qzhu2017 JSmol has been added in 9994626. Per c01e932, you'll need to unzip jsmol.zip in the right subfolder (where jsmol.js is).

After checking it out, what's your thoughts on the following open questions?

  • Default "Unit cell" size? (currently 1x1x1) Yes
  • Set "Unit cell" list options? (see current dropdown) no need to change
  • Is download as "json" needed? (see "xyz" under "Download" dropdown) I don't think we need this option
  • How best to implement on "Comparison" page? Two JSmols? Only the first? Maybe two JSmols and arrange them vertically? @sabaronett wow thanks. Are you coming to school tomorrow? or video meeting?
sabaronett commented 4 years ago

@qzhu2017, I'm coming to school tomorrow. I'll finish classes around 12:45 PM. Come to your office afterwards?

qzhu2017 commented 4 years ago

@sabaronett sounds good. see u tomorrow