search

qzind / qz-print

Archive for legacy qz-print versions (1.8, 1.9). See https://github.com/qzind/tray for modern versions.
Other
141 stars 101 forks source link

Page Refresh/GatewayDialog #11

Closed tresf closed 9 years ago

tresf commented 9 years ago

The Gateway dialog doesn't behave properly with page refreshes... It displays for the first WebSocket connection and the refreshed page doesn't receive the "Allow".

Steps to reproduce:

  1. Run QZ Tray
  2. Load sample_ws.html in a Web Browser.
  3. Click the tray to display the GatewayDialog
  4. Leave the GatewayDialog open and refresh the page on the browser
  5. Switch to the GatewayDialog, click Allow.
  6. Switch back to the web page, it is still yellow.
akberenz commented 9 years ago

Should be fixed via 5735b32ba5ceeb44640e94f83e0a81473985110d, the dialogs will now get queued up and displayed to the user.

tresf commented 9 years ago

@bberenz Terrific, thank you. @robertcasto this even works with the "Always Allow" because the dialog itself checks the certificate which checks the whitelist, thus essentially clicking "Yes" for every dialog that appears (so one "Yes" suppresses them all if the "Always allow" is checked. This works terrifically.

robertcasto commented 9 years ago

This is good to hear. Hopefully the other changes will go just as well.

On Wed, May 6, 2015 at 3:57 PM, Tres Finocchiaro notifications@github.com wrote:

@bberenz https://github.com/bberenz Terrific, thank you. @robertcasto https://github.com/robertcasto this even works with the "Always Allow" because the dialog itself checks the certificate which checks the whitelist, thus essentially clicking "Yes" for every dialog that appears. This works terrifically.

Reply to this email directly or view it on GitHub https://github.com/qzind/qz-print/issues/11#issuecomment-99586981.

Robert Casto Owner | SellersToolbox p: 1-513-847-4942 c: 1-513-886-1550 e: casto.robert@gmail.com www.sellerstoolbox.com Tools for Amazon Sellers

tresf commented 9 years ago

FYI, added new ConfirmDialog vi https://github.com/qzind/qz-print/commit/7598bddd61f924fa64c9d66048ee2524f65b64e3 for UI consistency and also to allow setAlwaysOnTop(true); similar to GatewayDialog as this too was getting hid behind other windows.

image